Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds shader based anisotropic filtering to the DX renderers.
Rationale behind Changes
DX lacks support for anisotropic filtering with point filtering, currently we switch to linear filtering
That, however, causes can cause issues when alpha test is used, as colours not intended to be visible get blended in due to linear filtering, see #14077.
Additionally, AMD doesn't perform AF on textures that lack mipmaps in DX12, despite the same working in VK.
This brings parity to how the VK render behaves on NV and AMD with AF.
Suggested Testing Steps
Enable anisotropic filtering along with the new shader anisotropic filtering option under Graphics->Rendering
Notably, the shader based approach is more aggressive then Nvidia's HW AF. which is noticeable at native res.
Did you use AI to help find, test, or implement this issue or feature?
No