Qt: Fix Big Picture Mode mnemonic shortcut lost after state change#14245
Open
Vishrut2403 wants to merge 1 commit intoPCSX2:masterfrom
Open
Qt: Fix Big Picture Mode mnemonic shortcut lost after state change#14245Vishrut2403 wants to merge 1 commit intoPCSX2:masterfrom
Vishrut2403 wants to merge 1 commit intoPCSX2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
onFullscreenUIStateChange()was setting the action text to"Start Big Picture Mode"(without the&mnemonic) when exiting Big Picture mode, while the.uifile correctly defines it as"Start Big Picture &Mode". This caused the keyboard shortcut to stop working after exiting Big Picture mode.Rationale behind Changes
The Qt mnemonic ampersand (
&) was missing from thetr()call inonFullscreenUIStateChange(), causing the underlined shortcut letter to disappear from the System menu after exiting Big Picture mode. The fix reuses strings that already exist in all translation files, so no translation updates are needed.Suggested Testing Steps
Fixes #13584
Did you use AI to help find, test, or implement this issue or feature?
No