Apple: Enable MaterialX for iOS Builds#2950
Closed
dgovil wants to merge 2 commits intoPixarAnimationStudios:devfrom
Closed
Apple: Enable MaterialX for iOS Builds#2950dgovil wants to merge 2 commits intoPixarAnimationStudios:devfrom
dgovil wants to merge 2 commits intoPixarAnimationStudios:devfrom
Conversation
Member
|
Thanks, @dgovil , but I think it would be preferable if this PR were literally just the one-liner in build_usd.py, unless there are API-breaking changes in the new patch-version? That way we can validate MaterialX behavior independently of any Apple/iOS-related changes. |
Collaborator
Author
|
Sure, I'll split it out further into just the MaterialX version upgrade : #2952 I've changed this PR to enable MaterialX support for iOS once the other PRs are merged in |
dgovil
changed the title
Collaborator
|
Filed as internal issue #USD-9313 |
dgovil
force-pushed
the
ios_core_with_mtlx
branch
from
5e64569 to
93bc898
Compare
This PR adds **Core** iOS support to the OpenUSD project. This does not include Imaging, and any Imaging related components at this time. Imaging will be added in a follow up PR. MaterialX is also disabled as requested and the upgrade will be handled in a follow up PR. It is a minimal version of PixarAnimationStudios#2455 against the latest `dev` branch. Changes include: * Using latest dev branch * No imaging support. Will be added in a follow up PR. * Makes use of CMake's inbuilt iOS support, negating the need for toolchain support * Structures the code in such a way that we can add support for other iOS derived platforms+simulator in future PRs * Swaps `ARCH_OS_IOS` with `ARCH_OS_IPHONE` to align with compiler directives. IPHONE refers to all derivative platforms, whereas iOS refers to only iPhone/iPad (Confusing but the case for historical reasons as [documented here](https://chaosinmotion.com/2021/08/02/things-to-remember-compiler-conditionals-for-macos-ios-etc/)) * TBB requires SDKROOT to be passed in or it can often go off and find some random compiler toolchain and fail. * Add APPLE_EMBEDDED boolean to designate when using the CMake supported cross compilation targets. Added in Options.cmake so it can be used to configure defaults properly.
dgovil
force-pushed
the
ios_core_with_mtlx
branch
from
93bc898 to
62b7cec
Compare
This requires PixarAnimationStudios#2949 to be merged first as that introduces core iOS support first
dgovil
force-pushed
the
ios_core_with_mtlx
branch
from
62b7cec to
53bc09a
Compare
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR updates MaterialX to 1.38.8 to add support for iOS builds. As requested, this has been split out from the Core iOS PR. Valentin Roussellet set up the majority of this PR.
This requires these PRs to be merged first: