[vt, sdf, usd] fix array-bounds warnings on GCC 13#4031
Open
nvidia-jomiller wants to merge 1 commit intoPixarAnimationStudios:devfrom
Open
[vt, sdf, usd] fix array-bounds warnings on GCC 13#4031nvidia-jomiller wants to merge 1 commit intoPixarAnimationStudios:devfrom
nvidia-jomiller wants to merge 1 commit intoPixarAnimationStudios:devfrom
Conversation
nvidia-jomiller
force-pushed
the
dev-array-bounds-warn-gcc
branch
from
8a385c8 to
5cfa483
Compare
Five false-positive warning sites caused by GCC 13 losing bound information during aggressive inlining. pxr/base/vt/streamOut.cpp Ensure dimension is less than Vt_ShapeData::NumOtherDims before indexing into shape.otherDims pxr/usd/sdf/schema.cpp Add TF_AXIOM(static_cast<size_t>(level) < std::size(valueTupleDimensions.d)) to the else-if in _AddValuesToValueContext. GCC cannot bound the plain size_t size member but can see std::size(d) == 2. pxr/usd/usd/clip.cpp Add TF_AXIOM(numTimes <= brackingTimes.size()) so GCC can see that numTimes is correctly bounded before std::sort
nvidia-jomiller
force-pushed
the
dev-array-bounds-warn-gcc
branch
from
5cfa483 to
7dac76b
Compare
Collaborator
|
Filed as internal issue #USD-12073 (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Three false-positive warning sites caused by GCC 13 losing bound information during aggressive inlining.
pxr/base/vt/streamOut.cpp
Vt_ShapeData::NumOtherDimsbefore indexing intoshape.otherDimspxr/usd/sdf/schema.cpp
TF_AXIOM(static_cast<size_t>(level) < std::size(valueTupleDimensions.d))to the else-if in_AddValuesToValueContext. GCC cannot bound the plain size_t size member but can see std::size(d) == 2.pxr/usd/usd/clip.cpp
TF_AXIOM(numTimes <= brackingTimes.size())so GCC can see thatnumTimesis correctly bounded before std::sort
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)