[sdf] fix array-bounds warning on GCC 13 for predicateLibrary.h#4032
Open
nvidia-jomiller wants to merge 1 commit intoPixarAnimationStudios:devfrom
Open
Conversation
Replace std::vector<bool> with std::vector<uint8_t> for boundArgs. The vector<bool> bit-packing specialisation triggers -Warray-bounds and -Wstringop-overflow when its word-level memmove is inlined into _TryBindArgs; uint8_t uses the standard path GCC analyzes correctly.
Collaborator
Author
|
Another way to deal with the warning caused by the |
Collaborator
|
Filed as internal issue #USD-12074 (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
std::vector<bool>withstd::vector<uint8_t>forboundArgs.The
vector<bool>bit-packing specialization triggers -Warray-bounds and-Wstringop-overflow when its word-level memmove is inlined into
_TryBindArgs; uint8_t uses the standard path GCC analyzes correctly.
Description of Change(s)
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)