Skip to content

[sdf] fix array-bounds warning on GCC 13 for predicateLibrary.h #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvidia-jomiller wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[sdf] fix array-bounds warning on GCC 13 for predicateLibrary.h #4032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pxr/usd/sdf/predicateLibrary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ class SdfPredicateLibrary
ParamType &param,
bool &boundAllParams,
std::vector<SdfPredicateExpression::FnArg> const &args,
std::vector<bool> &boundArgs,
std::vector<uint8_t> &boundArgs,
NamesAndDefaults const &namesAndDefaults) {

// Bind the index-th 'param' from 'args' &
Expand Down Expand Up @@ -550,7 +550,7 @@ class SdfPredicateLibrary
std::vector<SdfPredicateExpression::FnArg> const &args,
NamesAndDefaults const &namesAndDefaults,
std::index_sequence<I...>,
std::vector<bool> &boundArgs) {
std::vector<uint8_t> &boundArgs) {

// A fold expression would let us just do &&, but that's '17, so we just
// do all of them and set a bool.
Expand All @@ -572,7 +572,7 @@ class SdfPredicateLibrary
static void
_FillArbitraryArgs(std::true_type,
std::vector<SdfPredicateExpression::FnArg> const &args,
std::vector<bool> const &boundArgs,
std::vector<uint8_t> const &boundArgs,
Tuple &typedArgs) {
std::vector<SdfPredicateExpression::FnArg> &rest =
std::get<std::tuple_size<Tuple>::value-1>(typedArgs);
Expand All @@ -591,7 +591,7 @@ class SdfPredicateLibrary
static void
_FillArbitraryArgs(std::false_type,
std::vector<SdfPredicateExpression::FnArg> const &,
std::vector<bool> const &,
std::vector<uint8_t> const &,
T const &) {
// Do nothing.
}
Expand Down Expand Up @@ -657,7 +657,7 @@ class SdfPredicateLibrary
}

ParamsTuple typedArgs;
std::vector<bool> boundArgs;
std::vector<uint8_t> boundArgs;
if (_TryBindArgs(typedArgs, args, namesAndDefaults,
std::make_index_sequence<NumBindableArgs> {},
boundArgs)) {
Expand Down
Loading
⚡