[Agent] feat: AspectRatioOverride enum — Phase 2 of Screen Scaling standardization#3619
Open
github-actions[bot] wants to merge 1 commit intodevelopfrom
Open
[Agent] feat: AspectRatioOverride enum — Phase 2 of Screen Scaling standardization#3619github-actions[bot] wants to merge 1 commit intodevelopfrom
github-actions[bot] wants to merge 1 commit intodevelopfrom
Conversation
github-actions
bot
added
agent-work
Contributor
Author
|
🤖 PR created. AI review starting automatically. |
This was referenced Apr 3, 2026
github-actions
bot
force-pushed
the
agent/issue-2673-phase2
branch
2 times, most recently
from
47aee48 to
e448000
Compare
github-actions
bot
force-pushed
the
agent/issue-2673-phase2
branch
7 times, most recently
from
875545e to
bcdd414
Compare
…ation - Add AspectRatioOverride enum to PVPrimitives (auto/4:3/16:9/1:1/8:7/stretch) with displayName, subtitle, symbolName, aspectRatioValue, and isWidescreen metadata - Extend CoreOptional protocol with supportedAspectRatioOverrides and preferredAspectRatioOverride; default impls return .auto (no-op for all existing cores) - Enable scalingModeRenderer feature flag by default (was: disabled, gated behind flag) - Add AspectRatioOverrideTests covering raw values, CaseIterable, Codable, and display metadata - Update reviewer-context.md with ScalingMode + AspectRatioOverride review rules Part of #2673 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
force-pushed
the
agent/issue-2673-phase2
branch
from
bcdd414 to
6fe40f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the Screen Scaling standardization epic (#2673), following the merged Phase 1 (#3616).
AspectRatioOverrideenum — new type inPVPrimitiveswith 6 cases (auto,ratio_4_3,ratio_16_9,ratio_1_1,ratio_8_7,stretch). Each case carriesdisplayName,subtitle,symbolName,aspectRatioValue, andisWidescreenmetadata for UI use.CoreOptionalprotocol extensions —supportedAspectRatioOverrides(which overrides the core supports) andpreferredAspectRatioOverride(the currently selected one). Default implementations return[.auto]/.autoso all existing cores are completely unaffected.scalingModeRendererby default — the feature flag introduced in Phase 1 is nowenabled: true. The newScalingMode-driven renderer paths (Stretch, Aspect Fill, Integer Scale, Native Resolution) are active for all users. LegacynativeScaleEnabled/integerScaleEnabledshims remain for backwards compatibility.AspectRatioOverrideTestscovers raw values,CaseIterable,Codableround-trip,aspectRatioValue,isWidescreen, and display metadata..github/prompts/reviewer-context.mdwith Phase 1/2 review rules.What's Next (Phase 3)
Per-core wiring: cores that already have aspect ratio / widescreen support (Dolphin, PPSSPP, Flycast, DuckStation, Gearcoleco) will override
supportedAspectRatioOverridesandpreferredAspectRatioOverrideto read from their existingCoreOptionkeys.Test plan
cd PVPrimitives && swift test—AspectRatioOverrideTestsall passProvenance-Litescheme —scalingModeRendererflag now active by default; verify all ScalingMode picker values work in Settings > VideoPart of #2673