Perform fractional gate filtering on raw API dicts#2044
Merged
yaelbh merged 17 commits intoQiskit:mainfrom Nov 24, 2024
Merged
Conversation
wshanks
commented
Nov 15, 2024
This change moves the filtering of fractional gates and dynamic circuit instructions up into the processing of the raw configuration and properties dicts received through the API. Previously, the filtering was performed only during the creation of the `Target` for the backend. So previously an `IBMBackend` with fractional gates would have both fractional gates and dynamic circuit instructions in its configuration and properties data regardless of what value was used for `use_fractional_gates`. This situation led to inconsistent behavior when for example users tried to use `backend.basis_gates` as the reference for which gates were available instead of `backend.target.operation_names`. The previous changes to filter instructions during target creation are removed here, but the `use_fractional_gates` backend option is retained because `IBMBackend` loads the properties data lazily and can reload the configuration data after creation with the `refresh()` method. Closes Qiskit#2031
wshanks
force-pushed
the
fractional-filter
branch
from
41ff06f to
87ca03c
Compare
nkanazawa1989
previously requested changes
Nov 16, 2024
Contributor
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
Overall the change looks good. I have a couple of concerns as written in inline comments.
yaelbh
reviewed
Nov 18, 2024
Contributor
Author
|
I think this is ready for another look. |
yaelbh
requested changes
Nov 20, 2024
Collaborator
yaelbh
left a comment
yaelbh
left a comment
There was a problem hiding this comment.
Edit the comment in
Another comment to be edited, although it's not from this PR, but related:
And, of course, thanks a lot for doing this work 😄
yaelbh
reviewed
Nov 21, 2024
Collaborator
yaelbh
left a comment
yaelbh
left a comment
There was a problem hiding this comment.
Added a few small comments, although you didn't say that it's ready for another review
wshanks
commented
Nov 22, 2024
Contributor
Author
wshanks
left a comment
wshanks
left a comment
There was a problem hiding this comment.
Thanks, @yaelbh. I did mean to ask for another review after my last changes. I think it is ready again.
I think I have addressed all the comments, but I didn't mark anything as resolved. Feel free to mark any conversations as resolved if you want to clear up what is still outstanding.
wshanks
dismissed
nkanazawa1989’s stale review
Naoki is on leave and we don't want to make him come back early to re-review or wait for him to come back.
yaelbh
approved these changes
Nov 24, 2024
wshanks
added
the
Changelog: Bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the filtering of fractional gates and dynamic circuit instructions up into the processing of the raw configuration and properties dicts received through the API. Previously, the filtering was performed only during the creation of the
Targetfor the backend. So previously anIBMBackendwith fractional gates would have both fractional gates and dynamic circuit instructions in its configuration and properties data regardless of what value was used foruse_fractional_gates. This situation led to inconsistent behavior when for example users tried to usebackend.basis_gatesas the reference for which gates were available instead ofbackend.target.operation_names.Closes #2031