Promote CONTROL_FLOW_OP_NAMES to public API#13057
Merged
mtreinish merged 1 commit intoQiskit:mainfrom Aug 30, 2024
Merged
Conversation
This is generally useful for Qiskit's built-in transpiler passes, and we've had some interest in using it for the same reasons from outside the library. While the control-flow structure from within Rust might change in the future, in the immediate term and from Python space, it feels fair to expose this as public API, since all the information contained in it is certainly already public.
Collaborator
|
One or more of the following people are relevant to this code:
|
mtreinish
approved these changes
Aug 29, 2024
Pull Request Test Coverage Report for Build 10623602313Details
💛 - Coveralls |
Contributor
|
Lazy follow up request -- it would be nice to have an equivalent to qiskit/qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py Lines 459 to 464 in b9d5c9c It came up in Qiskit/qiskit-ibm-runtime#2044 (comment). I will keep it on my list but I can't do it at the moment. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is generally useful for Qiskit's built-in transpiler passes, and we've had some interest in using it for the same reasons from outside the library. While the control-flow structure from within Rust might change in the future, in the immediate term and from Python space, it feels fair to expose this as public API, since all the information contained in it is certainly already public.
Details and comments
Minor request from @ihincks.