Conversation
jfy133
approved these changes
Oct 23, 2025
| @click.option( | ||
| "--dates", | ||
| is_flag=True, | ||
| help="Generate AncientMetagenomeDir dates table of all samples in input table" |
Member
There was a problem hiding this comment.
Maybe mention its single genomes only currently?
Collaborator
Author
There was a problem hiding this comment.
Aida plans to add the dates for ancientmetagenome-hostassociated in the next hackathon. I wrote the function so that it will ignore this option when there is no dates table available for the category and instead returns an error message with an explanation.
I think this should be sufficient.
Member
|
Note not tested but looks simple enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
amdirt downloadamdirt convertAdditionally, it fixes the #175 issue by including the output folder in the filename.