This repository was archived by the owner on Jan 27, 2020. It is now read-only.
Code polishing for Compress Annotated VCFs#602
Merged
szilvajuhos merged 3 commits intoSciLifeLab:masterfrom Jun 20, 2018
Merged
Code polishing for Compress Annotated VCFs#602szilvajuhos merged 3 commits intoSciLifeLab:masterfrom
szilvajuhos merged 3 commits intoSciLifeLab:masterfrom
Conversation
Member
Author
|
@szilvajuhos That was meant to be with PR #599 |
szilvajuhos
reviewed
Jun 20, 2018
Collaborator
szilvajuhos
left a comment
There was a problem hiding this comment.
Do we really have to change basename to simplename? basename has a meaning/command in UNIX, simplename is something new we can not realte to.
Member
Author
|
|
Member
Author
|
And in this case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplification of channels.
Output is now:
_snpEff.ann.vcf.gzinstead of.snpEff.ann.vcf.gz_VEP.ann.vcf.gzinstead of.vep.ann.vcf.gz_snpEff_VEP.ann.vcf.gzinstead of.snpEff.ann.vcf.vep.ann.vcf.gz