Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

Code polishing for Compress Annotated VCFs#602

Merged
szilvajuhos merged 3 commits intoSciLifeLab:masterfrom
maxulysse:CompressAnnVCFs
Jun 20, 2018
Merged

Code polishing for Compress Annotated VCFs#602
szilvajuhos merged 3 commits intoSciLifeLab:masterfrom
maxulysse:CompressAnnVCFs

Conversation

@maxulysse
Copy link
Copy Markdown
Member

Simplification of channels.

Output is now:

  • _snpEff.ann.vcf.gz instead of .snpEff.ann.vcf.gz
  • _VEP.ann.vcf.gz instead of .vep.ann.vcf.gz
  • _snpEff_VEP.ann.vcf.gz instead of .snpEff.ann.vcf.vep.ann.vcf.gz

@maxulysse maxulysse requested a review from szilvajuhos June 20, 2018 07:45
@maxulysse
Copy link
Copy Markdown
Member Author

@szilvajuhos That was meant to be with PR #599

Copy link
Copy Markdown
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really have to change basename to simplename? basename has a meaning/command in UNIX, simplename is something new we can not realte to.

@maxulysse
Copy link
Copy Markdown
Member Author

baseName from sample.vcf.gz will get sample.vcf
So then we're getting .snpEff.ann.vcf.vep.ann.vcf.gz which is quite a long name.
simpleName get only what is before the first .
So with simpleName it will reduce that to only _snpEff_VEP.ann.vcf.gz

@maxulysse
Copy link
Copy Markdown
Member Author

And in this case baseName, simpleName or fileName are all used within Nextflow, so it's groovy magic in fact ;-)

@szilvajuhos szilvajuhos merged commit 3936cca into SciLifeLab:master Jun 20, 2018
@maxulysse maxulysse deleted the CompressAnnVCFs branch June 20, 2018 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants