Conversation
|
All changes look good. Wait for review from human collaborators. wixtoolset
|
|
! DON'T merge until consensus is made. |
|
This is why I made ScoopInstaller/Versions#1606 and this could be updated to v4. But this may break some codes in Scoop Core (https://github.com/ScoopInstaller/Scoop/blob/f93028001fbe5c78cc41f59e3814d2ac8e595724/lib/core.ps1#L318-L323 and https://github.com/ScoopInstaller/Scoop/blob/f93028001fbe5c78cc41f59e3814d2ac8e595724/libexec/scoop-checkup.ps1#L32-L34). Nevertheless, update wix to 4 and I'll update core soon (most users are install dark directly IMO). Ed. I made a commit instead of a review by mistake. Please review the last commit which was used by me locally @chawyehsu |
|
/verify |
|
All changes look good. Wait for review from human collaborators. wixtoolset
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. wixtoolset
|
|
This could be merged 'cos |
Don't know if it is proper to update to v4 directly but Wix 4 works totally different from its previous versions... This will be a breaking change I think. Wix 4 is required to unpack installers that are packed with Wix 4, which means
dark, removed in Wix 4, will not work anymore for this kind of installers, takingswiftas the example..P.S. Wix 5 release is planning..
Closes #XXXX
Relates to #5466, #5521