Skip to content

fix(decompress): Use wix.exe in WiX Toolset v4+ as primary extractor of Expand-DarkArchive()#5871

Merged
niheaven merged 3 commits intodevelopfrom
fix-dark
Apr 12, 2024
Merged

fix(decompress): Use wix.exe in WiX Toolset v4+ as primary extractor of Expand-DarkArchive()#5871
niheaven merged 3 commits intodevelopfrom
fix-dark

Conversation

@niheaven
Copy link
Copy Markdown
Member

@niheaven niheaven commented Apr 8, 2024

Description

dark is removed from WiX 4, and use wix burn extract to do the same job.

Motivation and Context

After merging to the master branch, only use dark for machines without .NET 6+ since WiX Toolset requires .NET SDK 6+ (? not tested).

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven changed the title fix(helper): Remove wixtoolset as dark's alternative fix(decompress): Use wix.exe in WiX Toolset v4+ as primary extractor of Expand-DarkArchive() Apr 8, 2024
@chawyehsu
Copy link
Copy Markdown
Member

WiX Toolset requires .NET SDK 6+ (? not tested)

YES

@niheaven
Copy link
Copy Markdown
Member Author

niheaven commented Apr 11, 2024

Since ScoopInstaller/Main#5552 is merged, could this be merged too? @chawyehsu

Could use python and swift as test apps

@niheaven niheaven merged commit 7054c9d into develop Apr 12, 2024
@niheaven niheaven deleted the fix-dark branch April 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants