feat(checkver): Add option to throw error as exception#4867
Merged
rashil2000 merged 1 commit intoScoopInstaller:developfrom Apr 14, 2022
CrendKing:checkver_throw_error
Merged
feat(checkver): Add option to throw error as exception#4867rashil2000 merged 1 commit intoScoopInstaller:developfrom CrendKing:checkver_throw_error
rashil2000 merged 1 commit intoScoopInstaller:developfrom
CrendKing:checkver_throw_error
Conversation
Member
|
Contributor
Author
|
Done. Any objection for the variable names? |
rashil2000
approved these changes
Apr 14, 2022
Member
|
LGTM |
issaclin32
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Closes #4863
This is the core part of the change. The GitHub Action part is at ScoopInstaller/GithubActions#5.
How Has This Been Tested?
I created a Scoop bucket repo with some manifests in it. One manifest is intentionally old and requires update.
autoupdateurl wrong so it can't complete the autoupdate process.THROW_ERRORoption to excavator.yml, make it '0'. Rerun the workflow. Observe the exact same result (because option is disabled as default).THROW_ERRORto '1'. Rerun the workflow. Observe the run is now failed and GitHub sends notification to me. The log shows an error is thrown.Checklist: