Entity Gliding#8588
Open
AnOwlBe wants to merge 28 commits into
Open
Conversation
…ssion for setting glide state adds effect for setting glide state added entitytoggleglideevent into skriptlang folder under 'bukkit -> entity'
AnOwlBe
requested review from
Pesekjak and
cheeezburga
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
Author
|
Ragebait intellij fucked with formatting for entire simplevents again.. |
Member
you gotta turn that setting off man |
Author
|
couldn't find the setting to disable it ;-; |
Member
|
Author
|
I disabled setting n its still doing it- |
skriptlang-automation
Bot
added
the
enhancement
skriptlang-automation
Bot
removed
the
needs triage
Efnilite
requested changes
Apr 25, 2026
sovdeeth
requested changes
Apr 25, 2026
Efnilite
requested changes
Apr 28, 2026
skriptlang-automation
Bot
removed
the
needs reviews
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…ects/EffGlide.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Author
|
whats unresolved I re added that file in one of these commits |
Efnilite
requested changes
Apr 29, 2026
ShaneBeee
suggested changes
Apr 29, 2026
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…o feature/EvtGlideStateChange
ShaneBeee
suggested changes
Apr 29, 2026
ShaneBeee
left a comment
ShaneBeee
left a comment
Contributor
There was a problem hiding this comment.
Captain nit pick is back with more feedback :)
….java Co-authored-by: Shane Bee <shanebolenback@me.com>
….java Co-authored-by: Shane Bee <shanebolenback@me.com>
…ects/EffGlide.java Co-authored-by: Shane Bee <shanebolenback@me.com>
This was referenced May 2, 2026
APickledWalrus
requested changes
May 5, 2026
…ects/EffGlide.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
…ects/EffGlide.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
….java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
….java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
…o feature/EvtGlideStateChange
sovdeeth
approved these changes
May 13, 2026
APickledWalrus
requested changes
Jun 12, 2026
APickledWalrus
left a comment
APickledWalrus
left a comment
Member
There was a problem hiding this comment.
Looks good so far. Just a few thoughts.
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the only way to make an entity glide is
set gliding of entity to true/falsewhich is deprecated due to skript not doing boolean-expressions anymore (so pickle tells me)so I added a
glideeffect (make %livingentities% ((start|begin) gliding|glide)make %livingentities% (stop[ ]gliding|no longer glide)Additionally removed EntityToggleGlideEvent from simple events
and added it to skriptlang folder under 'entitymodule'
(and obviously made it use the newer registersyntax system instead of the deprecated system it was previously using)
and on account of #8573 the glide event now supports glid(e|ing)
Solution
explained above
Testing Completed
Tested with no other plugins on paper server 1.21.11 everything works fine
Supporting Information
Completes: #8573
AI assistance: none