Deprecate boolean expressions

[Phill310]

Problem

We have moved away from Boolean Expressions in favor of effect+condition pairs.

Solution

I looked through the expressions to find boolean expressions which could be deprecated and replaced. I then created effects and conditions to replace the functionality of the deprecated expressions.

Testing Completed

Added a test for each effect:

• EffAI.sk
• EffGlowing.sk
• EffGravity.sk
• EffProjectileCriticalState.sk (I wasn't sure if you could test to see if a warning was sent. If there is a way it might be nice to add this to the test when the projectile isn't an arrow or trident)

Supporting Information

• ExprAI: Created effect, moved+updated condition
• ExprFlightMode: Already has effect + condition, deprecated expression
• ExprGlidingState: Entity Gliding #8588
• ExprGlowing: Created effect and condition
• ExprGravity: Created effect + condtion
• ExprProjectileCriticalState: Creates effect + condition

Please let me know if I missed any or if some of these don't count.

Completes: none
Related: none
AI assistance: none

[APickledWalrus]

Looking really good so far! Nice work.

[Phill310]

I would love some extra feedback on the gravity condition. I am not super happy with the current syntax. I was thinking about adding something along the lines of %entities% are affected by gravity and/or %entities% experience gravity.

I was also wondering if we should mark ExprFlightMode for deprecation

[Absolutionism]

Looks good with these last changes

[APickledWalrus]

Looks great so far! It might be worth supporting some kind of toggle variant for the effect patterns. This is something that is currently supported for these boolean expressions through EffToggle IIRC.