Correctly splitting the --extra-cmake-options input.#641
Merged
bartlettroscoe merged 1 commit intoTriBITSPub:masterfrom Feb 2, 2026
Merged
Conversation
bartlettroscoe
approved these changes
Jan 30, 2026
Member
bartlettroscoe
left a comment
bartlettroscoe
left a comment
There was a problem hiding this comment.
If this passes the tests, it should be fine to merge.
Description: The use of commandLineOptionsToList wraps the default .split() command which splits on whitespace, not commas. Fixes issue TriBITSPub#640.
bartlettroscoe
force-pushed
the
640_CorrectlySplitExtraCmakeOptions
branch
from
690543c to
27262c6
Compare
Member
|
Hum, for some reason, I can't get the GHA jobs to trigger. It says "Expected: Waiting for status to be reported" but I don't see anything happening. I rebased the branch off of 'master' and forced pushed and that did not trigger the GHA jobs. This must be some type of defect with GHA to explain this. The GHA was disabled for a while and that might be related here. I ran this branch locally and it passed. (I was running in a container which is why I created #642.) I will just force merge this. |
Contributor
Author
|
Thanks Ross! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The use of commandLineOptionsToList wraps the default .split() command which splits on whitespace, not commas.
Fixes issue #640.