Correctly splitting the --extra-cmake-options input#643
Merged
bartlettroscoe merged 1 commit intoTriBITSPub:masterfrom Feb 2, 2026
Merged
Conversation
Description: The use of commandLineOptionsToList wraps the default .split() command which splits on whitespace, not commas. Fixes issue TriBITSPub#640.
rabartlett1972
approved these changes
Feb 2, 2026
Collaborator
rabartlett1972
left a comment
rabartlett1972
left a comment
There was a problem hiding this comment.
We don't have automated tests for this argument, but for the simple use cases it supported before this change, it should be fine. (If not, we will add a test fix it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #641 to try to get GHA jobs to fire off