removed MANY unused desktop deps, will make project lighter and futur…#3118
Closed
removed MANY unused desktop deps, will make project lighter and futur…#3118
Conversation
Open
mcginty
approved these changes
Mar 5, 2026
…#3113) * add node upgrade guide * Update npm deps for node 20, new electron release * Update selenium and electron-chrome selenium plugin for end 2 end tests. Fixes the e2e stuff that fails on GitHub now that electron has changed versions. Added this step to new nodejs upgrade guide doc * Configure github CI to use the node version set in .nvmrc, removes additional hardcoded nodejs version config, and makes it easier to upgrade nodejs in the future and to keep tests on dev machines and github CI running with same dependencies --------- Co-authored-by: Isla <5048549+islathehut@users.noreply.github.com>
* fix android env var passthrough * fix android studio build * fix ios crash on captcha
bitmold
force-pushed
the
desktop-unused-deps
branch
2 times, most recently
from
6b850ce to
c3cd4b8
Compare
* Update auth * Update CHANGELOG.md
* Wait for tor kill to finish before moving on * Update CHANGELOG.md
* Closes #3123 Removes Superflous @peculiar/webcrypto dependency. Removes hacky JavaScript that was needed to override global.crypto - this was probably needed for along time because iOS was using nodejs12 until some recent work, hence having no global.crypto flag. - iOS and Android need the --experimental-global-webcrypto flag until nodejs mobile is rebuilt
bitmold
force-pushed
the
desktop-unused-deps
branch
from
c3cd4b8 to
d60959f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tons of stuff just not being used, makes loading the project a lot faster + and speeds up + simplifies all of these headache-inducing huge upgrades/migrations
Staging this PR against my #3113
node20instead ofdevelopPR to highlight just these diffs. This should be compared againstdevelopand reviewed once #3113 is merged.