Skip to content

Electron32#3119

Open
bitmold wants to merge 9 commits intodevelopfrom
electron32
Open

Electron32#3119
bitmold wants to merge 9 commits intodevelopfrom
electron32

Conversation

@bitmold
Copy link
Copy Markdown
Collaborator

@bitmold bitmold commented Mar 3, 2026

Keeping this as a draft until #3118 and the electron 31 PRs have been integrated.

Also just making the PR now to verify CI testing is as it should be.....

Bumps from electron 31 to 32,

@bitmold
Copy link
Copy Markdown
Collaborator Author

bitmold commented Mar 27, 2026

@mcginty @holmesworcester @islathehut

Now that #3138 has been merged, this electron 32 PR is ready for review.

For some reason, on develop after bootstrapping the package-lock.json for Desktop is changed with tons of deletions. Perhaps this was some mistake around #3138? So the first commit is unrelated, it just gets the repo to a clean slate. Then the second commit is the small changes needed for electrion 32, and updating the web driver for e2etests....

Note: that the CI is complaining again about a dependency. The only complaint it has is with electron 32, it's the same issue it gave when we upgraded electron last time. It'll stop giving an error when we hit electron 35, so this PR brings us one step closer. Once this is merged, the CI won't complain about this (it's only when deps change that it raises an error)

@bitmold bitmold marked this pull request as ready for review March 27, 2026 19:11
@bitmold
Copy link
Copy Markdown
Collaborator Author

bitmold commented Mar 27, 2026

Bah, somehow the e2e tests are breaking now... Fixing.,....

@bitmold bitmold force-pushed the electron32 branch 3 times, most recently from d56123e to f6d8d6d Compare March 28, 2026 00:01
@bitmold
Copy link
Copy Markdown
Collaborator Author

bitmold commented Apr 10, 2026

@islathehut @mcginty this is finally in a good state with everything passing except the dependency analyzer (and that's just cuz we haven't made it to v35 of electron yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant