Conversation
|
@mcginty @holmesworcester @islathehut Now that #3138 has been merged, this electron 32 PR is ready for review. For some reason, on Note: that the CI is complaining again about a dependency. The only complaint it has is with electron 32, it's the same issue it gave when we upgraded electron last time. It'll stop giving an error when we hit electron 35, so this PR brings us one step closer. Once this is merged, the CI won't complain about this (it's only when deps change that it raises an error) |
|
Bah, somehow the e2e tests are breaking now... Fixing.,.... |
d56123e to
f6d8d6d
Compare
…ig for cypress, this allows webUtils.getPathForFile in cypress tests
…hromatic test suite doesnt crash
…ave to mock it when running build-storybook, this fixes the failing chromatic test
… series quiet uses...
|
@islathehut @mcginty this is finally in a good state with everything passing except the dependency analyzer (and that's just cuz we haven't made it to v35 of electron yet) |
…sign path to this object for use on backend
Keeping this as a draft until #3118 and the electron 31 PRs have been integrated.
Also just making the PR now to verify CI testing is as it should be.....
Bumps from electron 31 to 32,