add test for nc_inq_var_chunking on classic files#1697
Merged
WardF merged 4 commits intoUnidata:masterfrom Apr 15, 2020
NOAA-GSD:ejh_not_on
Merged
add test for nc_inq_var_chunking on classic files#1697WardF merged 4 commits intoUnidata:masterfrom NOAA-GSD:ejh_not_on
WardF merged 4 commits intoUnidata:masterfrom
NOAA-GSD:ejh_not_on
Conversation
DennisHeimbigner
added a commit
to DennisHeimbigner/netcdf-c
that referenced
this pull request
Apr 15, 2020
re: Unidata#1693 1. Add functions to libdispatch/dnotnc4.c to support dispatch table operations that should work for any dispatch table, even if they do not do anything. Functions such as nc_inq_var_filter. 2. Modify selected dispatch tables to utilize the noop functions. 3. Extend nc_test/tst_formats.c to test. This is an extension of Ed's work to do this for chunking and deflate and szip. See PRs Unidata#1697 and Unidata#1692 As a side effect, elide libdispatch/dnotnc3.c since it is no longer used.
Member
|
Thanks @edhartnett, reviewing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1693
In this PR I add a test which demonstrates that nc_inq_var_chunking() correctly handles classic files, reporting that they are NC_CONTIGUOUS.