Skip to content

Support no-op dispatch functions#1698

Merged
WardF merged 4 commits intoUnidata:masterfrom
DennisHeimbigner:dispnoop.dmh
May 4, 2020
Merged

Support no-op dispatch functions#1698
WardF merged 4 commits intoUnidata:masterfrom
DennisHeimbigner:dispnoop.dmh

Conversation

@DennisHeimbigner
Copy link
Copy Markdown
Collaborator

re: #1693

  1. Add functions to libdispatch/dnotnc4.c to support
    dispatch table operations that should work for any
    dispatch table, even if they do not do anything.
    Functions such as nc_inq_var_filter.
  2. Modify selected dispatch tables to utilize
    the noop functions.
  3. Extend nc_test/tst_formats.c to test.

This is an extension of Ed's work to do this for
chunking and deflate and szip. See PRs
#1697
and
#1692

As a side effect, elide libdispatch/dnotnc3.c since
it is no longer used.

re: Unidata#1693

1. Add functions to libdispatch/dnotnc4.c to support
   dispatch table operations that should work for any
   dispatch table, even if they do not do anything.
   Functions such as nc_inq_var_filter.
2. Modify selected dispatch tables to utilize
   the noop functions.
3. Extend nc_test/tst_formats.c to test.

This is an extension of Ed's work to do this for
chunking and deflate and szip. See PRs
Unidata#1697
and
Unidata#1692

As a side effect, elide libdispatch/dnotnc3.c since
it is no longer used.
@DennisHeimbigner DennisHeimbigner requested a review from WardF as a code owner April 15, 2020 20:46
@WardF WardF self-assigned this Apr 15, 2020
@WardF WardF added this to the 4.8.0 milestone Apr 15, 2020
@WardF
Copy link
Copy Markdown
Member

WardF commented Apr 15, 2020

Thanks @DennisHeimbigner I'll get this in; would you mind updating the RELEASE_NOTES.md file? Thanks!

@WardF WardF merged commit 524bdd5 into Unidata:master May 4, 2020
@WardF
Copy link
Copy Markdown
Member

WardF commented May 4, 2020

Thanks @DennisHeimbigner

@DennisHeimbigner DennisHeimbigner deleted the dispnoop.dmh branch May 12, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants