Skip to content

Revamping the HDF5_VERSION logic.#2095

Merged
WardF merged 6 commits intomasterfrom
condaforge-hdf5-version-check.wif
Aug 31, 2021
Merged

Revamping the HDF5_VERSION logic.#2095
WardF merged 6 commits intomasterfrom
condaforge-hdf5-version-check.wif

Conversation

@WardF
Copy link
Copy Markdown
Member

@WardF WardF commented Aug 30, 2021

Revamping HDF5_VERSION logic flow in CMakeLists.txt. Originally, this information was only used to determine if we had met the minimum supported version threshold. It has grown since then. We now check for versions as a cmake-infrastructure provided environmental variable; if that is not available, we attempt to determine the version programmatically using code contributed (I believe) by @edwardhartnett. If we ultimately cannot determine the HDF5_VERSION through any method, cmake will exit with an error.

@WardF WardF added this to the 4.8.2 milestone Aug 30, 2021
@WardF WardF self-assigned this Aug 30, 2021
Comment thread CMakeLists.txt Outdated
# Check to see if HDF5 library is 1.10.6 or greater.
# Used to control path name conversion
####
IF(${HDF5_VERSION} VERSION_GREATER "1.10.5")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.8.22 version of HDF5 works fine for me in CI testing with netCDF.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardhartnett Do you mean 1.8.22 works for you in regards to the HDF5_UTF8_PATHS toggle in this block? Or do you mean in general? Taking a look back, the HDF5_VERSION_REQUIRED "minimum version gate" is set to 1.8.10. Our CI tests against 1.8.21, I'll take a look at bumping that to 1.8.22. I've just noticed a path by which HDF5_VERSION might not be checked to see if it meets the required version, so I'll be pushing that change as well.

@dopplershift
Copy link
Copy Markdown
Member

@WardF this is working in conda-forge/libnetcdf-feedstock#130 for the main build. Still getting a problem with nc_test4:

CMake Error at nc_test4/CMakeLists.txt:50 (IF):
  if given arguments:

    "VERSION_GREATER" "1.10.0"

  Unknown arguments specified

@WardF
Copy link
Copy Markdown
Member Author

WardF commented Aug 30, 2021

@dopplershift Thanks. I see no errors on the Windows system I'm building against, I'll go dive into the feedstock recipe and see if there is some useful information there for debugging/replicating this.

@WardF WardF merged commit 09e0e04 into master Aug 31, 2021
@WardF WardF deleted the condaforge-hdf5-version-check.wif branch August 31, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants