Skip to content

[NO MERGE] Testing upstream fixes for HDF5 detection#130

Closed
dopplershift wants to merge 2 commits intoconda-forge:masterfrom
dopplershift:cmake-test
Closed

[NO MERGE] Testing upstream fixes for HDF5 detection#130
dopplershift wants to merge 2 commits intoconda-forge:masterfrom
dopplershift:cmake-test

Conversation

@dopplershift
Copy link
Copy Markdown
Member

Testing potential upstream CMake fixes so that hopefully the next release is easier.

cc @WardF

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dopplershift
Copy link
Copy Markdown
Member Author

See Unidata/netcdf-c#2095.

@WardF
Copy link
Copy Markdown
Contributor

WardF commented Aug 31, 2021

@dopplershift It looks like the most recent checks failed for a new/unrelated reason. Could we restart them and see if the issue persists or if it was a one-off thing?

@WardF
Copy link
Copy Markdown
Contributor

WardF commented Aug 31, 2021

I've fixed the appveyor issue over on the netcdf-c repo; once we figure out the windows cmake issue here, I'll get everything merged back in together.

Need to make sure these are baselined against 4.8.1
@dopplershift
Copy link
Copy Markdown
Member Author

@WardF the failure was actually due to the patch failing to apply. I've changed how I'm generating it to now baseline against the v4.8.1 branch rather than master--plus a couple manual edits. I'd expect this one to work better.

@WardF
Copy link
Copy Markdown
Contributor

WardF commented Aug 31, 2021

@dopplershift Thanks! I appreciate your help in tracking this down. It looks like all the tests are passing, is there anything else on your end before I can check this off and merge the PR back over at Unidata/netcdf-c?

@dopplershift
Copy link
Copy Markdown
Member Author

I'm just waiting to see Drone pass (aarch64) to call this complete.

@dopplershift
Copy link
Copy Markdown
Member Author

Alright, hopefully this should make getting 4.8.2 built upon release much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants