[NO MERGE] Testing upstream fixes for HDF5 detection#130
[NO MERGE] Testing upstream fixes for HDF5 detection#130dopplershift wants to merge 2 commits intoconda-forge:masterfrom
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cc5ff1b to
f8e1148
Compare
|
@dopplershift It looks like the most recent checks failed for a new/unrelated reason. Could we restart them and see if the issue persists or if it was a one-off thing? |
|
I've fixed the appveyor issue over on the netcdf-c repo; once we figure out the windows cmake issue here, I'll get everything merged back in together. |
Need to make sure these are baselined against 4.8.1
8764146 to
d1bf9de
Compare
|
@WardF the failure was actually due to the patch failing to apply. I've changed how I'm generating it to now baseline against the v4.8.1 branch rather than master--plus a couple manual edits. I'd expect this one to work better. |
|
@dopplershift Thanks! I appreciate your help in tracking this down. It looks like all the tests are passing, is there anything else on your end before I can check this off and merge the PR back over at |
|
I'm just waiting to see Drone pass (aarch64) to call this complete. |
|
Alright, hopefully this should make getting 4.8.2 built upon release much easier. |
Testing potential upstream CMake fixes so that hopefully the next release is easier.
cc @WardF
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)