Skip to content

Run dashboard frontend tests in ci#22237

Merged
thijsoo merged 2 commits intotrunkfrom
run-dashboard-frontend-tests-in-ci
May 6, 2025
Merged

Run dashboard frontend tests in ci#22237
thijsoo merged 2 commits intotrunkfrom
run-dashboard-frontend-tests-in-ci

Conversation

@igorschoester
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester commented May 6, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Tests the @yoast/dashboard-frontend in the GitHub CI.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Did the CI execute the JS tests for the dashboard-frontend package?
  • Did they pass?

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

To PR: #22201

Where the delta was changed to fractions instead of a percentage
@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 6, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6d74eca6a761572724cbf61463092f677dd95179

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 52.895%

Totals Coverage Status
Change from base Build ca3f014a5a9b7fbd2a95d02b2003424ae489c376: 0.4%
Covered Lines: 29601
Relevant Lines: 57100

💛 - Coveralls

@thijsoo thijsoo added this to the 25.2 milestone May 6, 2025
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thijsoo thijsoo merged commit 6174895 into trunk May 6, 2025
26 checks passed
@thijsoo thijsoo deleted the run-dashboard-frontend-tests-in-ci branch May 6, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants