Skip to content

Feat/update layout redirects#22319

Merged
vraja-pro merged 12 commits intofeature/redirection20from
feat/update-layout-redirects
Jun 11, 2025
Merged

Feat/update layout redirects#22319
vraja-pro merged 12 commits intofeature/redirection20from
feat/update-layout-redirects

Conversation

@kyrylo-polozenko-newfold
Copy link
Copy Markdown
Contributor

@kyrylo-polozenko-newfold kyrylo-polozenko-newfold commented May 28, 2025

Context

This PR introduces the initial structure for the Redirections feature in the application. The goal is to establish a foundation for managing and displaying redirections within the admin interface.

Summary

This PR can be summarized in the following changelog entry:

Adds the basic structure and UI for the Redirections page in the WordPress SEO plugin.
Some components were also moved to the shared layer and reused on the settings and redirects pages

UI changes

This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

React frontend structure

@kyrylo-polozenko-newfold kyrylo-polozenko-newfold added UI change PRs that result in a change in the UI changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels May 28, 2025
@enricobattocchi enricobattocchi added this to the feature/redirection20 milestone May 29, 2025
Comment thread packages/js/src/components/SchemaTab.js
Comment thread packages/js/src/components/modals/WincherUpgradeCallout.js Outdated
Comment thread packages/js/src/general/components/alerts-list.js Outdated
Comment thread packages/js/src/general/components/sidebar-layout.js Outdated
Comment thread packages/js/src/redirects/components/filter-controls.js Outdated
Comment thread packages/js/src/redirects/components/filter-controls.js Outdated
Comment thread packages/js/src/redirects/app.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
@enricobattocchi
Copy link
Copy Markdown
Member

Hey @kyrylo-polozenko-newfold, my teammate @vraja-pro left a first round of comments above
One thing that's not clear to us is that in some files you have added the default values for params for unrelated components, I suppose it was because eslint was complaining? If so, you should probably try to fix any error/warning in the components you are introducing to avoid conflicts - we are in the process to fix the other warnings so there could be some overlap...

@kyrylo-polozenko-newfold
Copy link
Copy Markdown
Contributor Author

Hey @enricobattocchi
yes you are right I made these changes because I had warnings on eslint, I did a rollback

Comment thread packages/js/src/redirects/components/filter-controls.js Outdated
Comment thread packages/js/src/redirects/components/filter-controls.js Outdated
Comment thread packages/js/src/redirects/components/filter-controls.js Outdated
Comment thread packages/js/src/redirects/components/menu.js Outdated
Comment thread packages/js/src/redirects/components/route-error-fallback.js Outdated
@vraja-pro vraja-pro self-assigned this Jun 3, 2025
Comment thread packages/js/src/redirects/components/route-error-fallback.js
Comment thread packages/js/src/redirects/components/route-error-fallback.js Outdated
Comment thread packages/js/src/redirects/routes/redirect-method.js Outdated
Comment thread packages/js/src/redirects/routes/regex-redirects.js Outdated
return <>
<Button
id={ buttonId }
type="button"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type button is the default

id={ buttonId }
type="button"
variant="secondary"
className="yst-w-full yst-flex yst-items-center yst-justify-start yst-font-normal yst-text-sm yst-leading-6 yst-text-slate-500 yst-rounded-md yst-border-slate-300 yst-shadow-sm yst-py-1.5 yst-pl-2 yst-pr-3"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe some of the classes here are already part of the secondary variant and the button component.

Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/shared-admin/components/search/search.js Outdated
Comment thread packages/js/src/redirects/components/menu.js Outdated
Comment thread packages/js/src/redirects/components/menu.js Outdated
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@vraja-pro vraja-pro merged commit cb6e195 into feature/redirection20 Jun 11, 2025
36 of 37 checks passed
@vraja-pro vraja-pro deleted the feat/update-layout-redirects branch June 11, 2025 09:40
@vraja-pro vraja-pro mentioned this pull request Jul 28, 2025
18 tasks
@enricobattocchi enricobattocchi added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog UI change PRs that result in a change in the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants