Skip to content

Feature/redirection20#22460

Merged
enricobattocchi merged 52 commits intotrunkfrom
feature/redirection20
Jul 28, 2025
Merged

Feature/redirection20#22460
enricobattocchi merged 52 commits intotrunkfrom
feature/redirection20

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jul 28, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Refactors and improves the Redirect UI.

Relevant technical choices:

This PR combines the following individual PRs:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • ATP for the Redirect redesign, to be tested also with the Premium PR.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added this to the 25.7 milestone Jul 28, 2025
@vraja-pro vraja-pro added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Jul 28, 2025
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 83feb67068b7564d9d5a1a9944da54e6859a38e1

Details

  • 7 of 105 (6.67%) changed or added relevant lines in 21 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 52.641%

Changes Missing Coverage Covered Lines Changed/Added Lines %
admin/class-config.php 0 1 0.0%
admin/views/redirects.php 0 1 0.0%
packages/js/src/redirects/hooks/use-select-redirects.js 0 1 0.0%
packages/js/src/shared-admin/components/form/formik-value-change-field.js 0 1 0.0%
packages/js/src/shared-admin/components/sidebar-layout.js 2 3 66.67%
packages/js/src/redirects/constants/index.js 0 2 0.0%
packages/js/src/redirects/app.js 0 3 0.0%
packages/js/src/redirects/routes/app-routes.js 0 3 0.0%
packages/js/src/shared-admin/hooks/use-parsed-user-agent.js 0 3 0.0%
packages/js/src/redirects/components/menu.js 0 4 0.0%
Totals Coverage Status
Change from base Build ffaeae46693c81847ff6dc05579da9a295d34cc8: -0.02%
Covered Lines: 31020
Relevant Lines: 59696

💛 - Coveralls

Fix import and dropped prop types in favor of the jsdocs
@enricobattocchi enricobattocchi added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog UI change PRs that result in a change in the UI and removed changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Jul 28, 2025
@enricobattocchi enricobattocchi merged commit 517a519 into trunk Jul 28, 2025
71 of 75 checks passed
@enricobattocchi enricobattocchi deleted the feature/redirection20 branch July 28, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog UI change PRs that result in a change in the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants