Skip to content

Small tweaks to align the upsell to the updates in the premium page.#22433

Merged
thijsoo merged 2 commits intofeature/redirection20from
update-css-upsell-page
Jul 15, 2025
Merged

Small tweaks to align the upsell to the updates in the premium page.#22433
thijsoo merged 2 commits intofeature/redirection20from
update-css-upsell-page

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Jul 15, 2025

Context

  • We want to make sure the upsell page looks the same as the design of the actual page.

Summary

This PR can be summarized in the following changelog entry:

  • Updates some css for the upsell of the redirect feature.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure it looks the same as the upsell page on the design.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added this to the feature/redirection20 milestone Jul 15, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 15, 2025
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✅

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 15, 2025

Pull Request Test Coverage Report for Build 40f14ad881e3ac77d3b371e31e5e7a7bdd0d64c0

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 53.858%

Totals Coverage Status
Change from base Build 28b9322aacf3abf3002d4b11185f090080cbd5f8: 0.5%
Covered Lines: 30489
Relevant Lines: 57559

💛 - Coveralls

@thijsoo thijsoo merged commit e79f37f into feature/redirection20 Jul 15, 2025
19 checks passed
@thijsoo thijsoo deleted the update-css-upsell-page branch July 15, 2025 12:17
@vraja-pro vraja-pro mentioned this pull request Jul 28, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants