Skip to content

Disable ai optimize button for classic.#22364

Closed
thijsoo wants to merge 147 commits intohotfix/25.3.1from
disable-optimize-features-classic
Closed

Disable ai optimize button for classic.#22364
thijsoo wants to merge 147 commits intohotfix/25.3.1from
disable-optimize-features-classic

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Jun 18, 2025

Context

  • We want to disable the sparks button in the analysis for the classic editor.

Summary

This PR can be summarized in the following changelog entry:

  • Disables the AI sparkle button in the classic editor.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@igorschoester
Fix CountrySelector defaults
12f5b30
@igorschoester
Fix defaults for KeyphrasesTableRow and KeyphrasesTable
61b2241
@igorschoester
Add default value to Modal' children
438640b
@igorschoester
Add default value to PremiumUpsell' className
a8b6e02
@igorschoester
Refactor defaultProps to defaultArguments
1c7a255 
* fix JS doc
* use prop spreading
* specify which props in "areMarkButtonsHidden"
* remove unused "hasAIButton" prop
* remove import comments (as they interfere with my auto ordering)
@igorschoester
Decrease allowed warning count
e5dcd80 
Still 2 more than before the ESLint config bump. The defaults count as complexity, due to their if/else nature I suppose.
@igorschoester
Add default value to TableButton' SuccessMessage' variant
169b1de
@igorschoester
Fix JSDoc default for TableButton' className
a0c7a07 
Ignoring the warning for this one, since it is a false positive due to forwardRef
In the future forwardRef will also be irrelevant and passed as a prop
@igorschoester
Add default vale to RequestLimitReached' upsellLink
cf41489 
And fix return type in JSDoc
@igorschoester
Add default to UserMessage' variant
9a029fc 
* fix default in JSDoc
* fix return type in JSDoc
* auto-order imports
@igorschoester
Decrease allowed JS lint warnings
96311c3
@igorschoester
Refactor ImageSelect' defaultProps to defaultArguments
6fc0642 
* improve JSDoc
* use Lodash' noop instead of inline lambda creation
* auto editor styling fix in CSS
@igorschoester
Refactor ComponentWithCaret props to be destructured
011bdf5 
* add JSDoc
* improve JSDoc of wrapper method
* move propTypes to after definition
* add default to optional isPremium
@igorschoester
Change defaults of SocialMetadataPreviewForm
25b1d23 
* to use Lodash' noop instead of new empty lambda -- seems safer
* auto-reorder imports
* put semi-colon on the same line as closing template string
@igorschoester
Decrease allowed JS lint warnings
658f953 
1 left: the complexity, most likely added with the defaults
@igorschoester
Adapt snapshots
f89c344
@igorschoester
Add default arguments in stories
b25ea9d
@igorschoester
Add default to CheckboxGroup' options
4fce42b 
* adjust JSDoc
@igorschoester
Add defaults to DropdownMenu' className props
bb00c89 
* adjust JSDoc
@igorschoester
Add default to HOC in the FileImport' status
296e8ec 
* fix JSDoc
@igorschoester
Add defaults to Notifications and Notification' children
6f650c2 
* fix JSDoc
@igorschoester
Refactor Pagination defaultProps to defaultArguments
b794727 
* change the Button default of disabled to false instead of undefined -- I see no reason for it to not adhere to the type
* fix JSDoc
@igorschoester
Add defaults to Popover components
6d68a48
@igorschoester
Add defaults to RadioGroup
f0f673b 
* adjust JSDoc
@igorschoester
Add defaults to SidebarNavigation components
e6e5062 
* the openButtonId and closeButtonId are now nullable, an empty string would result in an empty attribute in the DOM
* adjust JSDoc
@igorschoester
Add defaults to Tooltip Container components
d9a417b 
* change the TooltipTrigger' ariaDescribedBy to be nullable to prevent empty tags in the DOM that would happen with an empty string
* adjust JSDoc
@igorschoester
Add default to AutoComplete.Option' children
e55665b
@igorschoester
Refactor Paper defaultProps to defaultArguments
d6ee8e2
@igorschoester
Refactor SkeletonLoader defaultProps to defaultArguments
c4243cc
@igorschoester
Add defaults to Toast components
fada646 
* specify the specific positions in the propTypes
* adjust JSDoc -- specifically the Description' description as ReactNode instead of string|string[] as per the propType specification
thijsoo and others added 23 commits June 11, 2025 11:01
@thijsoo
Merge pull request #22327 from Yoast/623-ignore-posts-that-are-noinde…
277ef9c 
…xed-even-if-the-whole-cpt-is-index

Use indexables for retrieving posts for the llms.txt file
@leonidasmi
Add BOM for UTF-8 to improve support for non-english characters
7fcca9e
@leonidasmi
Add unit tests
e12ff0e
@thijsoo
Merge pull request #22339 from Yoast/2326-253-issue-with-escaping-spe…
f9c1a61 
…cial-characters-in-llms-file-when-the-file-is-opened-in-the-browser

Add BOM for UTF-8 to improve support for non-english characters
Add changelog
e86428b
Bump version to 25.4-RC2
97ee388
@leonidasmi
Introduce filter that edits the file path of the llms.txt file
41f4359
@leonidasmi
Improve docs and namings
f50ddd0
@leonidasmi
Automatically fix issues in wp.com
484e2ea
@leonidasmi
Check if document root is available before using it
b79cc16
@thijsoo
Merge pull request #22340 from Yoast/624-allow-users-to-change-the-ab…
1424cd1 
…solute-filesystem-path-via-filter

Introduce filter that edits the file path of the llms.txt file
Add changelog
39f3130
Bump Gutenberg supported version.
e78c213
Bump version to 25.4-RC3
f9fad28
@leonidasmi
Replace flushing cache group with firing action instead
144a6c9
@leonidasmi
Fix unit tests
4d922ab
@thijsoo
Check to make sure the feature is enabled before we check the option.
f1afe10
@thijsoo
Add different copies
246cbe0
@thijsoo
One more test.
cffd96e
@leonidasmi
Merge pull request #22329 from Yoast/611-show-warning-in-yoast-dashbo…
bc172ab 
…ard-when-llmstxt-cant-be-created-nice-to-have

Add warning for when the LLMs.txt cannot be generated in our dashboard.
@thijsoo
Merge pull request #22349 from Yoast/22295-flushing-of-unused-group-o…
70bdcd1 
…rphaned_counts

Replace flushing cache group with firing action instead
@thijsoo
Disable ai optimize button for classic.
6f8f418
@thijsoo @enricobattocchi
Disable ai optimize button for classic.
7202ed5
@thijsoo thijsoo added this to the 25.3.1 milestone Jun 18, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 18, 2025
@FAMarfuaty FAMarfuaty requested a review from a team as a code owner June 18, 2025 09:45
@thijsoo thijsoo closed this Jun 18, 2025
@thijsoo thijsoo deleted the disable-optimize-features-classic branch October 7, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Milestone

25.3.1

Development

Successfully merging this pull request may close these issues.

9 participants

@thijsoo @igorschoester @FAMarfuaty @mhkuu @marinakoleva @agnieszkaszuba @leonidasmi @Jordi-PV @vraja-pro
⚡