Skip to content

Introduce new introduction about AI brand insights#22477

Merged
igorschoester merged 13 commits intorelease/25.7from
720-intro-modal-for-ai-brand-insights---pre-launch
Aug 5, 2025
Merged

Introduce new introduction about AI brand insights#22477
igorschoester merged 13 commits intorelease/25.7from
720-intro-modal-for-ai-brand-insights---pre-launch

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Aug 4, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds an announcement for the upcoming AI Brand Insights feature.

Relevant technical choices:

  • Unit tests were added in the old way of class-by-class basis, not method-by-method basis. This is because this is a fix-before-release where time is of the essence.
  • For the button, I wasn't able to find a button to re-use and I didn't add it in a way that's re-usable either, again because this is a fix-before-release where time is of the essence. We should improve on this, so I'm including the relevant Slack thread here.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • In a fresh site, visit an non-Yoast admin page and confirm that you don't get any introduction for a Yoast feature
  • Now, go to any Yoast admin page and confirm that you now get the introduction of the Yoast AI Brand Insight upcoming feature and its watchlist.
  • Compare it with the designs.
  • Confirm that the link is https://yoa.st/ai-brand-insights-introduction-pre-launch along with the link parameters we usually add.
  • Close the modal and refresh. Confirm that you dont get the modal again.
    • If you want to display the modal again for that user, find the _yoast_wpseo_introductions entry for the user in the usermeta table and delete it.
  • Now repeat the test in a site where you had Yoast before (the live version) and you have seen the previous introduction modal (the Google docs one). Confirm that:
    • you dont see the Google docs modal again
    • you do see the new modal about the AI Brand Insights
  • Repeat the tests with Premium enabled too

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added this to the 25.7 milestone Aug 4, 2025
@leonidasmi leonidasmi added the changelog: other Needs to be included in the 'Other' category in the changelog label Aug 4, 2025
@leonidasmi leonidasmi force-pushed the 720-intro-modal-for-ai-brand-insights---pre-launch branch from 01d333d to 50cac4f Compare August 4, 2025 13:20
@leonidasmi leonidasmi marked this pull request as ready for review August 4, 2025 14:13
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🏗️

Most notable for me is the CTB ID addition.

Comment thread packages/js/src/introductions/components/ai-brand-insights-pre-launch.js Outdated
Comment thread packages/js/src/introductions/components/ai-brand-insights-pre-launch.js Outdated
Comment thread packages/js/src/introductions/components/ai-brand-insights-pre-launch.js Outdated
Comment thread packages/js/src/introductions/components/ai-brand-insights-pre-launch.js Outdated
Comment thread packages/js/src/introductions/components/ai-brand-insights-pre-launch.js Outdated
Comment thread src/introductions/application/google-docs-addon-upsell.php
Comment thread images/ai-sparkle.svg
Comment thread css/src/introductions.css
Comment thread packages/js/src/introductions/components/ai-brand-insights-pre-launch.js Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 5, 2025

Pull Request Test Coverage Report for Build 3b5bf914cfd1b74169a998e08ff259a044057646

Details

  • 9 of 18 (50.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 720-intro-modal-for-ai-brand-insights---pre-launch at 52.654%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/introductions/components/content.js 0 2 0.0%
src/introductions/application/ai-brand-insights-pre-launch.php 8 11 72.73%
packages/js/src/introductions/components/ai-brand-insights-pre-launch.js 0 4 0.0%
Totals Coverage Status
Change from base Build 235c62e55191ee4ae22706e577151391c146c210: 52.7%
Covered Lines: 31031
Relevant Lines: 59701

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit 1d18730 into release/25.7 Aug 5, 2025
37 checks passed
@igorschoester igorschoester deleted the 720-intro-modal-for-ai-brand-insights---pre-launch branch August 5, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: other Needs to be included in the 'Other' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants