Add the Black Friday announcement modal#22507
Merged
thijsoo merged 13 commits intofeature/bf-2025from Aug 21, 2025
Merged
Conversation
…make alternating through introductions easier
Pull Request Test Coverage Report for Build e6a7e0b80499bdb8a730b54214937f6933fbef32Details
💛 - Coveralls |
… future and create the new BF one as prioritized
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
faa1047 to
6e7bafb
Compare
thijsoo
requested changes
Aug 21, 2025
Contributor
thijsoo
left a comment
There was a problem hiding this comment.
Acc 👍 two tiny suggestions.
| return isWooEnabled ? "yst-woo-introduction-gradient" : "yst-introduction-gradient"; | ||
| }, [ isWooEnabled ] ); | ||
|
|
||
| const ctb = useMemo( () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| const ctb = useMemo( () => { | |
| const ctbId = useMemo( () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Contentcomponent and make it into separate components for each introduction.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
_yoast_wpseo_introductionsis deleted), without Premium enabled/src/promotions/domain/black-friday-promotion.phpand make sure the bf promotion is active by changing line 16 to:yoa.st/black-friday-modal-ecommercewhen Woo is enabled andyoa.st/black-friday-modal-premiumwhen Woo is notdata-ctb-idisc7e7baa1-2020-420c-a427-89701700b607when Woo is enabled andf6a84663-465f-4cb5-8ba5-f7a6d72224b2when not._yoast_wpseo_introductionsusermeta and activate Premium/src/promotions/domain/black-friday-promotion.phpcode/src/promotions/domain/black-friday-promotion.phpcode and confirm that you now will see the BF modal once again./wp-admin/admin.php?page=wpseo_dashboard#/first-time-configuration)Regression test:
packages\js\src\introductions\initialize.js, change the"ai-brand-insights-pre-launch": AiBrandInsightsPreLaunch,line into"google-docs-addon-upsell": GoogleDocsAddonUpsell,(and addimport { GoogleDocsAddonUpsell } from "./components/modals/google-docs-addon-upsell";in the imports). Then insrc\introductions\application\ai-brand-insights-pre-launch.phpreturn false in the should_show() function and insrc\introductions\application\google-docs-addon-upsell.phpreturnreturn $this->current_page_helper->is_yoast_seo_page()in that same function.Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #