Skip to content

Add images for BF modals#22519

Merged
thijsoo merged 3 commits intofeature/bf-2025from
753-images-for-bf-announcement-modals
Aug 25, 2025
Merged

Add images for BF modals#22519
thijsoo merged 3 commits intofeature/bf-2025from
753-images-for-bf-announcement-modals

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds images for BF modals

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

image --- image

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 22, 2025
@leonidasmi leonidasmi added this to the feature/bf-2025 milestone Aug 22, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 22, 2025

Pull Request Test Coverage Report for Build f310013754bb91024cb03a14dae364a959de22f3

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 53.11%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/introductions/components/modals/black-friday-announcement.js 0 1 0.0%
Totals Coverage Status
Change from base Build 2acc881b6d4f4f8e2f33c0ee250b75fdc329d5d3: 0.5%
Covered Lines: 31545
Relevant Lines: 59916

💛 - Coveralls

@enricobattocchi enricobattocchi force-pushed the 753-images-for-bf-announcement-modals branch from cedfda7 to 3a83d00 Compare August 22, 2025 14:29
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit ef00ed0 into feature/bf-2025 Aug 25, 2025
19 checks passed
@thijsoo thijsoo deleted the 753-images-for-bf-announcement-modals branch August 25, 2025 10:47
@pls78 pls78 mentioned this pull request Aug 26, 2025
17 tasks
@pls78 pls78 modified the milestones: feature/bf-2025, 25.9 Aug 26, 2025
@enricobattocchi enricobattocchi mentioned this pull request Aug 27, 2025
17 tasks
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants