Adapt admin sidebar and footer upsell#22488
Merged
Conversation
Also added a parameter to get the condensed list of benefits
pls78
added
the
changelog: other
thijsoo
requested changes
Aug 12, 2025
| } | ||
|
|
||
| .yoast-sidebar__product .yoast-button-upsell { | ||
| background-color: rgb(252, 211, 77); |
Contributor
There was a problem hiding this comment.
This is also #fcd34d which we use in other places. so might wan to use that?
Contributor
There was a problem hiding this comment.
This is amber-300 from Tailwind. Could go @apply yst-bg-amber-300;
| margin-top: 0.3em; | ||
| font-size: 1.7em; | ||
| font-weight: bold; | ||
| color: rgb(166, 30, 105); |
Contributor
There was a problem hiding this comment.
This is our primary-500, so could go @apply yst-text-primary-500;
thijsoo
force-pushed
the
adapt-admin-sidebar-and-footer-upsell
branch
from
c537e04 to
3b6c784
Compare
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Toolspage and the ones shown in the other pages. This is because theToolspage is plain html + css, whileGeneral,Settings, andSupportpages uses React and Tailwind (see this Slack Thread).Toolspage by adding a@mediacss directive.packages/js/src/shared-admin/components/premium-upsell-list.jsbecause adding the new check about WooCommerce would require some refactoring and I didn't have time to do that in this issue. That check is going to be re-instated in the dedicated BF ads issue.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
GeneralSettingsToolsSupport( sidebar ad only)and verify the footer and sidebar ads are about Yoast SEO Premium and follow the designs here
yoa.st/admin-footer-upsell-woocommerceyoa.st/admin-sidebar-upsell-woocommerceTools, which we still show - also in production)Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #715