Update styling for the black friday ads.#22497
Merged
vraja-pro merged 6 commits intofeature/bf-2025from Aug 19, 2025
Merged
Conversation
thijsoo
added
the
changelog: non-user-facing
vraja-pro
reviewed
Aug 18, 2025
| if ( YoastSEO()->classes->get( Promotion_Manager::class )->is( 'black-friday-promotion' ) ) { | ||
| $bf_label = esc_html__( 'BLACK FRIDAY', 'wordpress-seo' ); | ||
| $sale_label = esc_html__( '30% OFF', 'wordpress-seo' ); | ||
| $sale_label = esc_html__( '30% OFF WordPress SEO', 'wordpress-seo' ); |
Contributor
There was a problem hiding this comment.
The name of the product is wrong
vraja-pro
reviewed
Aug 18, 2025
| className="yst-rounded-t-lg yst-h-9 yst-flex yst-justify-between yst-items-center yst-bg-black yst-text-amber-300 yst-px-4 yst-text-lg yst-border-b yst-border-amber-300 yst-border-solid yst-font-medium" | ||
| > | ||
| <div>{ __( "30% OFF", "wordpress-seo" ) }</div> | ||
| <div>{ __( "30% OFF WORDPRESS SEO", "wordpress-seo" ) }</div> |
Contributor
There was a problem hiding this comment.
The name of the product is wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
new Time_Interval( \gmmktime( 10, 00, 00, 11, 28, 2024 ), \gmmktime( 10, 00, 00, 12, 3, 2026 ) )GeneralSettingsToolsSupport( sidebar ad only)and verify the footer and sidebar ads are about Yoast SEO Premium and follow the designs here
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #