Skip to content

Add target blank to sidebar menu via JS#22555

Merged
vraja-pro merged 1 commit intorelease/26.0from
767-upgrade-button-in-sidebar-should-open-a-new-tab
Sep 9, 2025
Merged

Add target blank to sidebar menu via JS#22555
vraja-pro merged 1 commit intorelease/26.0from
767-upgrade-button-in-sidebar-should-open-a-new-tab

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Sep 8, 2025

Context

  • We want to open de upgrades page in a new tab.

Summary

This PR can be summarized in the following changelog entry:

  • Makes the upgrade button in the WordPress sidebar open in a new tab.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure that our Upgrades button in the WP sidebar opens in a new tab.
  • With premium make sure there are no JS errors.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 8, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build d6a15e7b85f26b56d8cbed75a6bcba7d5462d1c3

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 53.26%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/admin-global.js 0 4 0.0%
Totals Coverage Status
Change from base Build c7dc657b718d057bb276c15d62fc8ad77f72b792: 0.5%
Covered Lines: 31724
Relevant Lines: 59771

💛 - Coveralls

@vraja-pro vraja-pro added this to the 26.0 milestone Sep 9, 2025
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro changed the base branch from trunk to release/26.0 September 9, 2025 13:34
@vraja-pro vraja-pro merged commit 166ff8a into release/26.0 Sep 9, 2025
21 checks passed
@vraja-pro vraja-pro deleted the 767-upgrade-button-in-sidebar-should-open-a-new-tab branch September 9, 2025 13:36
@vraja-pro vraja-pro mentioned this pull request Sep 19, 2025
17 tasks
@leonidasmi leonidasmi mentioned this pull request Oct 7, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants