Skip to content

Update badges#22572

Merged
vraja-pro merged 12 commits intofeature/ai-insights-adsfrom
update-ai-brand-insights-upsells
Sep 19, 2025
Merged

Update badges#22572
vraja-pro merged 12 commits intofeature/ai-insights-adsfrom
update-ai-brand-insights-upsells

Conversation

@pls78
Copy link
Copy Markdown
Member

@pls78 pls78 commented Sep 16, 2025

Context

  • N/A

Summary

This PR can be summarized in the following changelog entry:

  • Updates the Upgrade buttons in WordPress sidebar and admin bar to be shown to all users with a New badge.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Use the following Figma designs to check the UI implementation:
    • Sidebar
    • Admin bar
      The elements in the design are organized in the following order: Free, Free + BF campaing, Premium, Premium + BF Campaing
Yoast SEO only
  • Start with only Yoast SEO activated

  • In the backend, check that both the Upgrade button in the sidebar and in the admin bar is unchanged

  • Check the sidebar button redirects to https://yoast.com/reasons-to-upgrade

  • Check the admin bar one points to https://yoa.st/admin-bar-get-premium

Yoast SEO + WooCommerce
  • Activate WooCommerce
    • Check the buttons look same as before
      • Check the sidebar one now redirects you to https://yoast.com/rtu-woocommerce-seo/
      • Check the admin bar one points to https://yoa.st/admin-bar-get-premium-woocommerce
Yoast SEO only + BF campaign
  • Deactivate Woocommerce
  • Edit src/promotions/domain/black-friday-promotion.php
    • Change line 16 to new Time_Interval( \gmmktime( 10, 00, 00, 11, 27, 2023 ), \gmmktime( 10, 00, 00, 12, 2, 2025 ) )
  • In the backend, check the two buttons and make sure they look as in the design
Yoast SEO + WooCommerce + BF campaign
  • Activate WooCommerce
    • Check the buttons look same as before
      • Check the sidebar one now redirects you to https://yoast.com/rtu-woocommerce-seo/
      • Check the admin bar one points to https://yoa.st/admin-bar-get-premium-woocommerce
Yoast SEO Premium
  • Edit src/promotions/domain/black-friday-promotion.php
    • Change line 16 back to new Time_Interval( \gmmktime( 10, 00, 00, 11, 27, 2025 ), \gmmktime( 10, 00, 00, 12, 2, 2025 ) )
  • Deactivate WooCommerce
  • Activate Yoast SEO Premium
  • Check the two buttons now look like in the design
  • Check the sidebar button redirects to the Yoast homepage (we still don't have the page for this)
  • Check the admin bar one points to https://yoa.st/admin-bar-get-ai-insights
Yoast SEO Premium + BF campaign
  • Edit src/promotions/domain/black-friday-promotion.php
  • Change line 16 to new Time_Interval( \gmmktime( 10, 00, 00, 11, 27, 2023 ), \gmmktime( 10, 00, 00, 12, 2, 2025 ) )
  • Check the two buttons look like in the design
  • Check the sidebar button redirects to the Yoast homepage (we still don't have the page for this)
  • Check the admin bar one points to https://yoa.st/admin-bar-get-ai-insights
  • Repeat the two Premium cases and verify nothing changes if you activate WooCommerce

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #779

@pls78 pls78 force-pushed the update-ai-brand-insights-upsells branch from 113ce3f to ee51e6a Compare September 16, 2025 11:22
@pls78 pls78 changed the base branch from trunk to feature/ai-insights-ads September 16, 2025 11:24
@pls78 pls78 added this to the feature/ai-insights-ads milestone Sep 16, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1ff1d0d666f3736999bac73099312af33fd1cc07

Details

  • 1 of 15 (6.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 52.739%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inc/class-wpseo-admin-bar-menu.php 1 4 25.0%
src/plans/user-interface/upgrade-sidebar-menu-integration.php 0 11 0.0%
Totals Coverage Status
Change from base Build 291e2f3fbb6dcfc7315fbdcaaaa8b6ecd0c36e4e: -0.5%
Covered Lines: 31226
Relevant Lines: 59331

💛 - Coveralls

@pls78 pls78 added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 16, 2025
@pls78 pls78 changed the title Update ai brand insights upsells Update badges Sep 17, 2025
@pls78 pls78 marked this pull request as ready for review September 17, 2025 08:25
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sidebar link doesn't open up in a new tab. Check out this PR #22555

@vraja-pro
Copy link
Copy Markdown
Contributor

With only Yoast SEO (free) Admin bar link doesnt points to https://yoa.st/admin-bar-get-premium. I get https://yoast.com/reasons-to-upgrade/

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

Both links is free redirects to /reasons-to-upgrade

@vraja-pro vraja-pro merged commit 6ec2b17 into feature/ai-insights-ads Sep 19, 2025
31 checks passed
@vraja-pro vraja-pro deleted the update-ai-brand-insights-upsells branch September 19, 2025 10:55
@pls78 pls78 removed this from the feature/ai-insights-ads milestone Sep 22, 2025
@pls78 pls78 added this to the 26.1 milestone Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants