Skip to content

727 improve re usability of ai buttons fix#22600

Merged
thijsoo merged 3 commits intotrunkfrom
727-improve-re-usability-of-ai-buttons-fix
Sep 25, 2025
Merged

727 improve re usability of ai buttons fix#22600
thijsoo merged 3 commits intotrunkfrom
727-improve-re-usability-of-ai-buttons-fix

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Implement new variant for the gradient button from the ai-frontend package on the insight introduction.

Relevant technical choices:

  • I cleaned up the css related to the gradient button since we are using the ai-frontend package.
  • I Added the ai-frontend package to the new settings dependencies.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Delete the introductions user meta (yoast_wpseo_introductions) to trigger the insights modal again.
  • Go to one of yoast admin pages like the settings page.
  • Smoke test the insights introduction modal gradient button.
  • Check the the focus is on the gradient button.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes ai-frontend package

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 25, 2025
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19327e305ee7ad98f770164d24e454f707739ef6

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 727-improve-re-usability-of-ai-buttons-fix at 41.613%

Totals Coverage Status
Change from base Build ed41ad5dbaf816698bf747d566d76927bb467dc9: 41.6%
Covered Lines: 22174
Relevant Lines: 49836

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo added this to the 26.2 milestone Sep 25, 2025
@thijsoo thijsoo merged commit c3ee3f9 into trunk Sep 25, 2025
48 of 50 checks passed
@thijsoo thijsoo deleted the 727-improve-re-usability-of-ai-buttons-fix branch September 25, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants