Skip to content

Revert 727 improve reusability of ai buttons fix#22651

Merged
thijsoo merged 2 commits intorelease/26.2from
revert-727-improve-reusability-of-ai-buttons-fix
Oct 16, 2025
Merged

Revert 727 improve reusability of ai buttons fix#22651
thijsoo merged 2 commits intorelease/26.2from
revert-727-improve-reusability-of-ai-buttons-fix

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Oct 16, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • In a fresh site or with reset user meta _yoast_wpseo_introductions.
  • Go to Yoast SEO->General
  • Check you see the introduction modal for the ai insights with the gradient button.
  • Dismiss the modal and check the sidebar is in place.
Screenshot 2025-10-16 at 11 35 43

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2643

@vraja-pro vraja-pro added this to the 26.2 milestone Oct 16, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build a367465172e6222a3402b0d834b618deec8fd345

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.212%

Totals Coverage Status
Change from base Build 53638595633848007d5d192adf5f2474696a9bd8: 0.0%
Covered Lines: 31851
Relevant Lines: 60137

💛 - Coveralls

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 16, 2025
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thijsoo thijsoo merged commit c295bdf into release/26.2 Oct 16, 2025
39 of 42 checks passed
@thijsoo thijsoo deleted the revert-727-improve-reusability-of-ai-buttons-fix branch October 16, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants