Skip to content

change capitalisation#22604

Merged
pls78 merged 3 commits intorelease/26.1from
789-fix-editor-premium-analysis-ads-title
Sep 29, 2025
Merged

change capitalisation#22604
pls78 merged 3 commits intorelease/26.1from
789-fix-editor-premium-analysis-ads-title

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Sep 26, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes capitalisations in the new editor's SEO analysis ads.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Note

In the RC the woocommerce ads would be only for a product. After #22605 is merged.

  • Disable premium if it's enabled and edit a post.
  • Click on the SEO analysis tab and check the title of the ad is "Premium SEO Analysis" analysis should be capitalized.
  • Activate woocommerce and edit a post
  • Click on the SEO analysis tab, you should see the blue ad.
  • Check the title of the ad is "Premium SEO Analysis" analysis should be capitalized.
Screenshot 2025-09-26 at 16 00 06 Screenshot 2025-09-26 at 16 00 29

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/789

@vraja-pro vraja-pro added this to the 26.1 milestone Sep 26, 2025
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 26, 2025
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Acc: 🚧
The same ad in the sidebar has the title in all caps, while we want it with just the first capital letter (see design here).

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7ee209361fb6cdbb1af18462be78b93e61cc2904

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 789-fix-editor-premium-analysis-ads-title at 30.109%

Totals Coverage Status
Change from base Build 3a4d89582e9720bd926060325988c1c25f77cade: 30.1%
Covered Lines: 4862
Relevant Lines: 14873

💛 - Coveralls

Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the WooCommerce ad is still capitalized.

Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acc: ✅

@pls78 pls78 merged commit 811e43d into release/26.1 Sep 29, 2025
29 of 31 checks passed
@pls78 pls78 deleted the 789-fix-editor-premium-analysis-ads-title branch September 29, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants