Skip to content

fix woo ads on products only#22605

Merged
thijsoo merged 3 commits intorelease/26.1from
2609-261-woo-upsell-on-a-post
Sep 29, 2025
Merged

fix woo ads on products only#22605
thijsoo merged 3 commits intorelease/26.1from
2609-261-woo-upsell-on-a-post

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Sep 26, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where WooCommerce SEO ad would be visible when not on a product page.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Activate WooCommerce
  • Edit a post and click on the SEO analysis tab
  • Check you see the Premium ad:
  • Screenshot 2025-09-26 at 16 00 29
  • Edit a product and click on the SEO analysis tab
  • Check you see the woocommerce seo ad
Screenshot 2025-09-26 at 16 23 58
  • Activate Woo SEO analysis and check you see the woocommerce SEO ad has the premium labeled button (Unlock with Premium).

Test the upsell modals.

  • Check the upsell modals theme is blue with a cart only on a product, there are 3 modal to test, you can trigger them by:
    • Click on the toggle " + Add related keyphrase".
    • Click on the toggle "Internal linking suggestions".
    • Edit a post in elementor. Click on the toggle "Readability" and then on the eye icon with the lock. Make sure your content has consecutive sentences or passive voice. (only for premium) Check with and without woocommerce and woo seo.
Screenshot 2025-09-29 at 12 39 48

Dummy text for the elementor upsells:

Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Activate the Yoast Free and Premium plugins.
Activate the Classic editor plugin.
Activate and give consent to use the Yoast AI features in the Yoast settings.
Open a post in Classic editor with some content and a keyphrase to make sure that the AI Optimize buttons are available in the SEO or Readability assessments.
Reload the page (or re-open the post).

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2609

@vraja-pro vraja-pro added this to the 26.1 milestone Sep 26, 2025
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 26, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 29, 2025

Pull Request Test Coverage Report for Build c9e42486c7a299771f32c2dadd9b18185821c1bb

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 2609-261-woo-upsell-on-a-post at 30.097%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/components/contentAnalysis/WooSeoAnalysisUpsellAd.js 0 1 0.0%
packages/js/src/components/contentAnalysis/PremiumSeoAnalysisUpsellAd.js 0 2 0.0%
packages/js/src/components/modals/UpsellModal.js 0 4 0.0%
Totals Coverage Status
Change from base Build 3a4d89582e9720bd926060325988c1c25f77cade: 30.1%
Covered Lines: 4862
Relevant Lines: 14875

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit 488e137 into release/26.1 Sep 29, 2025
25 of 26 checks passed
@thijsoo thijsoo deleted the 2609-261-woo-upsell-on-a-post branch September 29, 2025 10:37
@vraja-pro vraja-pro mentioned this pull request Sep 29, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants