Skip to content

Notify other admins of Yoast SEO#22644

Merged
vraja-pro merged 9 commits intotrunkfrom
poc/notify-new-other-admins
Oct 16, 2025
Merged

Notify other admins of Yoast SEO#22644
vraja-pro merged 9 commits intotrunkfrom
poc/notify-new-other-admins

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Oct 14, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Notifies other admins of Yoast SEO.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Note: The below are no longer relevant, because of #22661.

  • Install and activate Yoast SEO for the first time in your site (or deactivate Yoast on your existing site and then manually delete from the db all wpseo options and then activate the plugin)
  • Log in with a different user and confirm that you see the topbar and sidebar notifying that you have at least one notification
  • Go to the alert center and confirm that you see this alert:
image
  • The link there points to https://yoa.st/new-admin-newsletter-sign-up along with the usual shortlink parameters.
  • The dismiss button will refresh the page and hide that alert forever
  • If you want to make the alert re-appear, delete the wpseo-ping-other-admins_resolved usermeta for that user
  • Create a new admin (or SEO manager) and repeat the test
    • At the end of the tests, resolve the new alert and confirm that for any other admins, the alert still displays.
  • In a fresh site, install/activate via WP CLI (run wp plugin activate wordpress-seo)
    • The feature will not work, but the plugin activation went without problems
    • which means that no user will see that alert ever, no matter new or old.
    • check the first_activated_by setting in the wpseo option and confirm that it is equal to zero.
  • In a fresh site, install Yoast SEO normally and with the same user confirm that you dont see the new alert ever.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 14, 2025

Pull Request Test Coverage Report for Build cb89a6a01502cb4cb755e84fa13a60dfc392d13b

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 95 (6.32%) changed or added relevant lines in 5 files are covered.
  • 74 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.4%) to 53.254%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inc/class-wpseo-installation.php 0 1 0.0%
packages/js/src/admin-global.js 0 7 0.0%
src/alerts/user-interface/resolve-alert-route.php 0 28 0.0%
src/alerts/application/ping-other-admins/ping-other-admins-alert.php 0 53 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/installation-success.js 2 66.67%
packages/js/src/shared-admin/components/academy-upsell-card.js 2 50.0%
src/presenters/admin/sidebar-presenter.php 10 0.0%
packages/js/src/shared-admin/components/premium-upsell-list.js 10 6.06%
admin/class-premium-upsell-admin-block.php 50 0.0%
Totals Coverage Status
Change from base Build 99c83c550452bfb79a03d6ccb8e025a1f81c0906: 0.4%
Covered Lines: 31971
Relevant Lines: 60292

💛 - Coveralls

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 15, 2025
@leonidasmi leonidasmi force-pushed the poc/notify-new-other-admins branch from 9dabc3e to 2ec12b4 Compare October 15, 2025 09:53
@leonidasmi leonidasmi marked this pull request as ready for review October 16, 2025 06:11
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅

@vraja-pro
Copy link
Copy Markdown
Contributor

AC ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants