Skip to content

Revert notifying other admins of Yoast SEO#22661

Merged
pls78 merged 1 commit intotrunkfrom
postpone-other-admins-alert
Oct 21, 2025
Merged

Revert notifying other admins of Yoast SEO#22661
pls78 merged 1 commit intotrunkfrom
postpone-other-admins-alert

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Reverts notifying other admins of Yoast SEO.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Follow the test instructions for Notify other admins of Yoast SEO #22644 but confirm that you never see the new alert.
  • Instead of seeing the new alert, confirm that in the DB, there's the first_activated_by option that always shows the ID of the user that activated the plugin (or 0 if it was installed via WP CLI)

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • [] I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 20, 2025
@leonidasmi leonidasmi added this to the 26.3 milestone Oct 20, 2025
@leonidasmi leonidasmi mentioned this pull request Oct 20, 2025
17 tasks
@pls78 pls78 self-assigned this Oct 21, 2025
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 marked this pull request as ready for review October 21, 2025 08:32
@pls78 pls78 merged commit 4a8ef86 into trunk Oct 21, 2025
47 of 52 checks passed
@pls78 pls78 deleted the postpone-other-admins-alert branch October 21, 2025 08:32
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19a970a13fef7ba40bbb159d0746dc885fad816a

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 52.78%

Files with Coverage Reduction New Missed Lines %
src/alerts/application/ping-other-admins/ping-other-admins-alert.php 1 0.0%
Totals Coverage Status
Change from base Build 631b55e6a20fed8a15ef0bccfb634e30278ae758: -0.5%
Covered Lines: 31468
Relevant Lines: 59786

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants