Skip to content

842 task list create the redux slice#22726

Merged
FAMarfuaty merged 17 commits intofeature/task-listfrom
842-task-list-create-the-redux-slice
Nov 19, 2025
Merged

842 task list create the redux slice#22726
FAMarfuaty merged 17 commits intofeature/task-listfrom
842-task-list-create-the-redux-slice

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Nov 18, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/dashboard-frontend 0.0.1] Adds selectors and actions to the task list redux slice.
  • [@yoast/dashboard-frontend 0.1.0] Exports the TaskRow component.
  • [@yoast/dashboard-frontend 0.0.1] Support optional how text for the Task modal.
  • Adds the tasks table to the tasks tab.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to General -> Task list
  • Check the 3 tasks appear in the table like the design. Check all the tasks appear in the table like the design.
  • Click on the arrow and check the modal opens and appears like the design.
  • Click on the button for the llms.txt and check the button is disabled and the task is marked as completed in the table. No need for this, we're checking it with this PR instead.
  • Open the network tab and check the request get_tasks is not triggered on tab change.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Task list: Create the redux slice.

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 18, 2025
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 19, 2025

Pull Request Test Coverage Report for Build 5a5de28d27bf08053f9917d1367974ce6d18648a

Details

  • 7 of 57 (12.28%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 53.179%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/general/components/task.js 1 9 11.11%
packages/js/src/general/routes/task-list.js 0 18 0.0%
packages/dashboard-frontend/src/store/task-list.js 2 26 7.69%
Files with Coverage Reduction New Missed Lines %
packages/js/src/general/routes/task-list.js 1 3.23%
Totals Coverage Status
Change from base Build cf9a5ebaa839841fd3dab219d5d16cf74054342b: 0.5%
Covered Lines: 32376
Relevant Lines: 61181

💛 - Coveralls

Comment thread packages/dashboard-frontend/src/task-list/components/task-row.js Outdated
@FAMarfuaty FAMarfuaty added the innovation Innovative issue. Relating to performance, memory or data-flow. label Nov 19, 2025
Comment thread packages/js/src/general/components/task.js Outdated
vraja-pro and others added 3 commits November 19, 2025 15:23
@FAMarfuaty
Copy link
Copy Markdown
Contributor

Neat solution! 🙌🏽
CR & AT ✅

@FAMarfuaty FAMarfuaty merged commit e022658 into feature/task-list Nov 19, 2025
19 checks passed
@FAMarfuaty FAMarfuaty deleted the 842-task-list-create-the-redux-slice branch November 19, 2025 14:39
@leonidasmi leonidasmi added this to the feature/task-list milestone Nov 25, 2025
@leonidasmi leonidasmi mentioned this pull request Nov 27, 2025
18 tasks
@leonidasmi leonidasmi modified the milestones: feature/task-list, 26.6 Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants