873 task list handling ux of completing a task

[FAMarfuaty]

Context

Summary

This PR can be summarized in the following changelog entry:

• [@yoast/dashboard-frontend 0.1.0] Adds complete status component inside TaskModal.
• [@yoast/dashboard-frontend 0.1.0] Adds a loading state for the button of "default" and "delete" task type.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Loading and completed status

• Go to General -> Task list
• Open the modal of a task that is not completed yet.
• Confirm that there is no completed status rendered next to the duration
• Make sure that the task for llms.txt is not yet completed
• Open the modal for this task
• Throttle your network so it's very slow: otherwise it's hard to test the loading state. For example set the upload and download to 10kbit/s
• Click the Enable llms.txt button
• Confirm that the button now contains a spinner and the text says "Generating..."
• The design for the loading buttons should match this design
• Once the llms.txt is enabled, you can see the completed status next to the duration
• Confirm that the button is now disabled
• Confirm that the Modal title color becomes slate-500
• Confirm that the completed status matches the design
• Now exit the Task list tab and navigate to a different tab
• Navigate back to Task list
• Open the modal for the llms.txt task and confirm that you still see the completed status and that the title color is still slate-500
• Also test in RTL and confirm that the completed status component is still correctly rendered

For devs

• Spin up the storybook of the dashboard-frontend package
• Navigate to Task Modal component
• Set the isCompleted prop to true
• Confirm that the component renders the completed status and that the modal title is rendered with the correct color
• Set the isCompleted prop to false
• Set the isLoading prop to true
• Set the callToAction's type to "delete"
• Toggle the modal open
• Confirm that when the type is "delete", the button now has a loading spinner and the text says "Deleting..."
• Set the callToAction's type to "default"
• Toggle the modal open
• Confirm that when the type is "default", the button now has a loading spinner and the text says "Generating..."
• The design for the loading buttons should match this design

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• N/A

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.
• I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/872 & https://github.com/Yoast/reserved-tasks/issues/873

[coveralls]

Pull Request Test Coverage Report for Build 3c1ebe478326c8c2e66175f3d973e76e2ed41e73

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 53.174%

---

Totals
Change from base Build 532baabfb1cb7c380c65c15f2a2c90999add59e1:	0.02%
Covered Lines:	32389
Relevant Lines:	61233

---

💛 - Coveralls

[leonidasmi]

CR + Acceptance test is ✅

I left two tiny comments @FAMarfuaty only one of which requires some action, if you agree.