Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

windows: restore window position#123

Merged
gruehle merged 9 commits intomasterfrom
randy/restore-window-position
Oct 12, 2012
Merged

windows: restore window position#123
gruehle merged 9 commits intomasterfrom
randy/restore-window-position

Conversation

@redmunds
Copy link
Copy Markdown
Contributor

@redmunds redmunds commented Oct 3, 2012

Glenn submitted a fix for this on Mac, so now we can take this fix for Windows.

Comment thread appshell/cefclient_win.cpp Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the GROUP_NAME and APP_NAME constants defined in config.h instead of hard-coding "Brackets"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and PREF_BRACKETS_BASE should be given a more generic name like PREF_APPSHELL_BASE, too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ghost ghost assigned gruehle Oct 3, 2012
@redmunds
Copy link
Copy Markdown
Contributor Author

redmunds commented Oct 3, 2012

Code review changes pushed.

@redmunds
Copy link
Copy Markdown
Contributor Author

redmunds commented Oct 9, 2012

This is for: adobe/brackets#1594

Comment thread appshell/cefclient_win.cpp Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the GROUP_NAME macro, if defined, already has a backslash at the end of it (see config.h for edge code). In that case, you'll either need to omit the backslash when copying from pGroup, or omit it here before appending pApp.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I made it so any string passed to this function works with or without a trailing backslash.

@gruehle
Copy link
Copy Markdown
Member

gruehle commented Oct 10, 2012

Initial review complete.

@redmunds
Copy link
Copy Markdown
Contributor Author

@gruehle Changes pushed.

@gruehle
Copy link
Copy Markdown
Member

gruehle commented Oct 12, 2012

Looks good. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants