Put an array of all the color names in ColorUtils#10303
Put an array of all the color names in ColorUtils#10303redmunds merged 2 commits intoadobe:masterfrom
Conversation
|
I like this method better than stuffing them in the regex, but I'll need to check what changes I need to make to the Inline Color Editor to use this. 👍 |
There was a problem hiding this comment.
Just in case this is accepted, can you go ahead and add rebeccapurple to this array (#10250)?
|
They are still in the regex, so you don't have to change anything. |
|
This looks good. I agree that |
|
@redmunds I will close #10252 in favor of this. @marcelgerber Whoops, missed that. GitHub's long single-line diffs are hard for me to read. |
|
I think we need #9596 first for rebeccapurple to work properly, right? |
|
Added support for Sooner or later, we should, of course, merge #9596 for full support. |
|
@marcelgerber I am going to try to finish up #9596 today. |
|
@redmunds While you're online, can you look into merging this too so we can finish up |
There was a problem hiding this comment.
Minor nit, does not totally need fixing: I'd reword this to
Sorted array of all the color names in the CSS Color Module Level 3 and 4 (http://www.w3.org/TR/css3-color/).
I don't think we need to specifically state what color(s) from CSS4 is supported, as ideally we'd support all of them.
There was a problem hiding this comment.
I don't think Module Level 4 is ready yet, while Level 3 is.
While it's still in development, we should state which names are available.
|
Looks good. Merging. |
Put an array of all the color names in ColorUtils
So we (and extension developers) can reuse them whereever we want.
The actual regex is unchanged, it's just getting generated now.