[CLOSED] Put an array of all the color names in ColorUtils

[core-ai-bot]

Issue by MarcelGerber
Saturday Jan 03, 2015 at 23:23 GMT
Originally opened as adobe/brackets#10303

---

So we (and extension developers) can reuse them whereever we want.
The actual regex is unchanged, it's just getting generated now.

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/10303/commits

[core-ai-bot]

Comment by le717
Monday Jan 05, 2015 at 16:44 GMT

---

I like this method better than stuffing them in the regex, but I'll need to check what changes I need to make to the Inline Color Editor to use this. 👍

[core-ai-bot]

Comment by MarcelGerber
Monday Jan 05, 2015 at 18:13 GMT

---

They are still in the regex, so you don't have to change anything.

[core-ai-bot]

Comment by redmunds
Tuesday Jan 06, 2015 at 03:36 GMT

---

This looks good. I agree that rebeccapurple should be added to the list.

[core-ai-bot]

Comment by le717
Tuesday Jan 06, 2015 at 03:48 GMT

---

@redmunds I will close #10252 in favor of this.

@MarcelGerber Whoops, missed that. GitHub's long single-line diffs are hard for me to read.

[core-ai-bot]

Comment by MarcelGerber
Tuesday Jan 06, 2015 at 10:38 GMT

---

I think we need #9596 first for rebeccapurple to work properly, right?
I don't know what happens right now if you try to open an color inline editor on rebeccapurple, though.

[core-ai-bot]

Comment by MarcelGerber
Tuesday Jan 06, 2015 at 14:03 GMT

---

Added support for rebeccapurple (and changed comments in order to match the color names included).
Still, the Color Inline Editor doesn't work too well with rebeccapurple (see adobe/brackets#10250 (comment)) (Quick View works perfectly fine, btw), but imho we can still merge it as there won't be many out there wanting to edit rebeccapurple anyway, I guess.

Sooner or later, we should, of course, merge #9596 for full support.

[core-ai-bot]

Comment by le717
Tuesday Jan 06, 2015 at 14:11 GMT

---

@MarcelGerber I am going to try to finish up #9596 today.

[core-ai-bot]

Comment by le717
Friday Jan 16, 2015 at 19:40 GMT

---

@redmunds While you're online, can you look into merging this too so we can finish up rebeccapurple support?

[core-ai-bot]

Comment by redmunds
Friday Jan 16, 2015 at 19:49 GMT

---

Looks good. Merging.