This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Port missing piece of the indent-wrap hack from Codemirror. Fixes #11963#11964
Merged
abose merged 1 commit intoadobe:masterfrom Dec 1, 2015
Merged
Port missing piece of the indent-wrap hack from Codemirror. Fixes #11963#11964abose merged 1 commit intoadobe:masterfrom
abose merged 1 commit intoadobe:masterfrom
Conversation
Contributor
|
I tried the above steps, but I couldn't repro the issue in my machine. Tabs work fine with the above steps. Am I missing some steps? |
Collaborator
Author
|
@abose Hmm, there shouldn't be any other steps: just make sure that your Brackets indentation mode is set to Unless there are some difference between platforms how the tabs are handled. I am running on Windows 8.1. at the moment. |
abose
added a commit
that referenced
this pull request
Dec 1, 2015
Port missing piece of the indent-wrap hack from Codemirror. Fixes #11963
Contributor
|
|
Collaborator
Author
|
🆒 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11909 we added a
lineRenderhack from https://codemirror.net/demo/indentwrap.html. This hack alone works fine for files using spaces as whitespace. However, the PR was missing this additional hack from the pages stylesheet:This PR adds that, thus fixing #11963
@abose @stowball @rroshan1
edit: Steps to repro:
<h1>Foo</h1>-> Text doesn't move at all
After PR:
<h1>Foo</h1>-> Tabs work as indented and the
indent-wraphack still works too