[CLOSED] Port missing piece of the indent-wrap hack from Codemirror. Fixes #11963

[core-ai-bot]

Issue by petetnt
Tuesday Dec 01, 2015 at 07:48 GMT
Originally opened as adobe/brackets#11964

---

In #11909 we added a lineRender hack from https://codemirror.net/demo/indentwrap.html. This hack alone works fine for files using spaces as whitespace. However, the PR was missing this additional hack from the pages stylesheet:

      .CodeMirror pre > * { text-indent: 0px; }

This PR adds that, thus fixing #11963

@abose@stowball@rroshan1

edit: Steps to repro:

1. Create new file foo.html
2. Set indentation to Tab size: 4 from Brackets
3. Write <h1>Foo</h1>
4. Try to indent it with by pressing tab
   -> Text doesn't move at all

After PR:

1. Create new file foo.html
2. Set indentation to Tab size: 4 from Brackets
3. Write <h1>Foo</h1>
4. Try to indent it with by pressing tab
   -> Tabs work as indented and the indent-wrap hack still works too

---

petetnt included the following code: https://github.com/adobe/brackets/pull/11964/commits

[core-ai-bot]

Comment by abose
Tuesday Dec 01, 2015 at 09:29 GMT

---

I tried the above steps, but I couldn't repro the issue in my machine. Tabs work fine with the above steps. Am I missing some steps?

[core-ai-bot]

Comment by petetnt
Tuesday Dec 01, 2015 at 09:41 GMT

---

@abose Hmm, there shouldn't be any other steps: just make sure that your Brackets indentation mode is set to tabs. The width of .cm-tab is 0px so negative text-indent eats away the padding-left, resulting in zero indentation.

Unless there are some difference between platforms how the tabs are handled. I am running on Windows 8.1. at the moment.

[core-ai-bot]

Comment by abose
Tuesday Dec 01, 2015 at 10:08 GMT

---

"useTabChar" preference was not set. Now I can repro this.
Verified that works. Merging.
Thanks@petetnt

[core-ai-bot]

Comment by petetnt
Tuesday Dec 01, 2015 at 10:09 GMT

---

🆒