This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Return the result of calling the original jquery focus() function#5364
Merged
RaymondLim merged 1 commit intomasterfrom Sep 27, 2013
Merged
Return the result of calling the original jquery focus() function#5364RaymondLim merged 1 commit intomasterfrom
RaymondLim merged 1 commit intomasterfrom
Conversation
This commit 8e5ad95 fixed a focus issue with HTML menus. On Linux (where we still use HTML menues), the new implementation of focus didn't return the result when calling the original jquery focus implementation. The result was an error opening modal dialogs like Extension Manager, About Box, etc. The dialogs didn't work properly anymore due to this error: "Uncaught TypeError: Cannot call method 'trigger' of undefined" in bootstrap- modal.js This fix returns the result from calling the original focus function.
Member
Author
|
@RaymondLim This is just @ingorichter's original commit. Good to merge? |
ghost
assigned
Contributor
|
Thanks @peterflynn. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Sep 27, 2013
Return the result of calling the original jquery focus() function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as PR #5346 - except without the conflicting 2nd commit that we wound up not needing due to #5350.